Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToolsPanel: refactor Storybook examples to TypeScript, fix types inconsistencies #47944

Merged
merged 21 commits into from
Feb 13, 2023
Merged

ToolsPanel: refactor Storybook examples to TypeScript, fix types inconsistencies #47944

merged 21 commits into from
Feb 13, 2023

Commits on Feb 13, 2023

  1. Rename files

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    78dde7f View commit details
    Browse the repository at this point in the history

  2. Fix imports

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    cb303b8 View commit details
    Browse the repository at this point in the history

  3. Allow panelId to be null across all types

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    ef78ee9 View commit details
    Browse the repository at this point in the history

  4. ToolsPanel: mark hasInnerWrapper and `shouldRenderPlaceholderItem… 

    …s` as optional, assign `false` default value
    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    e7c1977 View commit details
    Browse the repository at this point in the history

  5. ToolsPanelItem: mark resetAllFilter as optional, assign noop de… 

    …fault value
    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    25cd91f View commit details
    Browse the repository at this point in the history

  6. ToolsPanelItem: change isShownByDefault to be optional, assign de… 

    …fault `false` value
    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    1496c0e View commit details
    Browse the repository at this point in the history

  7. Storybook examples: add component and state types

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    cd98b45 View commit details
    Browse the repository at this point in the history

  8. Storybook example: ignore unsolved errors, add TODO notes

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    c79f4f5 View commit details
    Browse the repository at this point in the history

  9. Add Storybook meta object

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    21ec6c6 View commit details
    Browse the repository at this point in the history

  10. Fix type errors in Storybook examples

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    38ad0a1 View commit details
    Browse the repository at this point in the history

  11. Remove extraneous isFirstToolsPanelItemShownByDefault prop from Sto… 

    …ry args
    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    e174f5a View commit details
    Browse the repository at this point in the history

  12. CHANGELOG

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    0df37ca View commit details
    Browse the repository at this point in the history

  13. Fix resetAll prop forwarding typo

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    2780f5d View commit details
    Browse the repository at this point in the history

  14. Update ResetAllFilter type to receive and return data. Update READMEs

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    fa0f4cf View commit details
    Browse the repository at this point in the history

  15. Update READMEs to sync resetAll and resetAllFilter types and desc… 

    …riptions
    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    02528f6 View commit details
    Browse the repository at this point in the history

  16. Remove @ts-ignore comments after updating the ResetAllFilter type

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    82f83bf View commit details
    Browse the repository at this point in the history

  17. Remove unnecessary ToolsPanelWithItemGroupSlot story

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    3577c50 View commit details
    Browse the repository at this point in the history

  18. update resetAll prop descritption in types JSDocs

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    4aad2e2 View commit details
    Browse the repository at this point in the history

  19. Fix ToolsPanel component exports

    @aaronrobertshaw @ciampo
    aaronrobertshaw authored and ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    8673259 View commit details
    Browse the repository at this point in the history

  20. Draft ToolsPanel JSDoc example comment

    @aaronrobertshaw @ciampo
    aaronrobertshaw authored and ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    86d61c7 View commit details
    Browse the repository at this point in the history

  21. Update CHANGELOG to avoid duplicate sections

    @ciampo
    ciampo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    c6ecc6b View commit details
    Browse the repository at this point in the history