Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List View: Scroll selected block into view when single block selection changes #46895

Merged
merged 10 commits into from
Feb 15, 2023
Merged

List View: Scroll selected block into view when single block selection changes #46895

merged 10 commits into from
Feb 15, 2023

Commits on Feb 14, 2023

  1. List View: Try scrolling selected blocks into view when single block … 

    …selection changes
    @andrewserong
    andrewserong committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    0c6e470 View commit details
    Browse the repository at this point in the history

  2. Use getScrollContainer and calculate real top position of scrollable … 

    …area instead of using a hard-coded value
    @andrewserong
    andrewserong committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    3513bbb View commit details
    Browse the repository at this point in the history

  3. Try rearranging things so that the ref is always attached at the row … 

    …level
    @andrewserong
    andrewserong committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    9531c0e View commit details
    Browse the repository at this point in the history

  4. Move placeholder to its own file

    @andrewserong
    andrewserong committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    068f3e9 View commit details
    Browse the repository at this point in the history

  5. Tidy up a little

    @andrewserong
    andrewserong committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    0854a37 View commit details
    Browse the repository at this point in the history

  6. Tidy comments

    @andrewserong
    andrewserong committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    df93475 View commit details
    Browse the repository at this point in the history

  7. Remove unneeded optional chaining 

    Co-authored-by: Kai Hao <kevin830726@gmail.com>
    @andrewserong @kevin940726
    andrewserong and kevin940726 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    018734e View commit details
    Browse the repository at this point in the history

  8. Simplify and improve logic based on feedback 

    Co-authored-by: Kai Hao <kevin830726@gmail.com>
    @andrewserong @kevin940726
    andrewserong and kevin940726 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    68f7147 View commit details
    Browse the repository at this point in the history

  9. Remove unneeded optional chaining 

    Co-authored-by: Kai Hao <kevin830726@gmail.com>
    @andrewserong @kevin940726
    andrewserong and kevin940726 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    0e64fd1 View commit details
    Browse the repository at this point in the history

  10. Revert placeholder component, update showBlock logic so that selected… 

    … blocks are rendered as real ListViewBlock components
    @andrewserong
    andrewserong committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1e6580a View commit details
    Browse the repository at this point in the history