Lodash: Refactor block editor away from _.find()
#46577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
geriux,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +61 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
WunderBart
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
- Verify block tools popover still appears properly for each block. ✅
- In a paragraph block, verify alignment options still work as before. ✅
- Verify you're still able to apply custom styles to blocks - colors, typography, etc. Make sure to also test gradients. ✅
- Verify that custom styles remain as blocks are being transformed just like they worked before. ✅
- Verify inserter search still works well, particularly as you search for a category name (like "media"). ✅
- Verify links in various blocks still work well - adding, removing, editing. ✅
- Verify setting an image to link to something still works well - to a media file, attachment, and to an existing page/post. ✅
- Verify the names of reusable blocks still work in the inserter. ✅
- Verify all checks are green. ✅
Tested locally, everything works as expected. Thanks! 🙌
tyxla
force-pushed
the
refactor/lodash-find-block-editor
branch
from
85367c6
to
a25793d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.find()from theblock-editorpackage. There are a few usages in that package and conversion is pretty straightforward.Since that removes the last usage of
_.find(), we're also deprecating the function completely for the repository.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Array.prototype.find()instead of_.find(). We're adding optional chaining for areas that could potentially be nullish.Testing Instructions