Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run PHPUnit jobs across multiple PHP versions #46510

Merged
merged 79 commits into from
Jan 16, 2023
Merged

Run PHPUnit jobs across multiple PHP versions #46510

merged 79 commits into from
Jan 16, 2023

Commits on Jan 12, 2023

  1. Add a small change to create a PR.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    b555d9d View commit details
    Browse the repository at this point in the history

  2. Add multiple php versions.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    6547f78 View commit details
    Browse the repository at this point in the history

  3. Add multiple php versions.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4bf84bb View commit details
    Browse the repository at this point in the history

  4. Define phpVersion as environment variable.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    1285d42 View commit details
    Browse the repository at this point in the history

  5. Add phpunit tags for PHP 8.1 and 8.2.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    cd74382 View commit details
    Browse the repository at this point in the history

  6. Remove hyphen.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    20e6d53 View commit details
    Browse the repository at this point in the history

  7. Nove PHPUnit tests to a separate file.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f192e2e View commit details
    Browse the repository at this point in the history

  8. Disable fail-fast.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    0da70ae View commit details
    Browse the repository at this point in the history

  9. Update matrix.os.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c3bbb6a View commit details
    Browse the repository at this point in the history

  10. Install composer dependencies.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    9b6cd40 View commit details
    Browse the repository at this point in the history

  11. Revert "Install composer dependencies." 

    This reverts commit e433d83.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    53180a4 View commit details
    Browse the repository at this point in the history

  12. Revert "Revert "Install composer dependencies."" 

    This reverts commit 5e13c24.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    b60db3d View commit details
    Browse the repository at this point in the history

  13. Fixing "no phpunit found" error.

    @aaroncampbell @anton-vlasenko
    aaroncampbell authored and anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    2a687ae View commit details
    Browse the repository at this point in the history

  14. Revert "Fixing "no phpunit found" error." 

    This reverts commit ee42215.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c161a74 View commit details
    Browse the repository at this point in the history

  15. Add phpunit tags for PHP 8.1 and 8.2.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4381998 View commit details
    Browse the repository at this point in the history

  16. Debug the phpunitImage.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f340a41 View commit details
    Browse the repository at this point in the history

  17. Use correct composer version.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    aa50d13 View commit details
    Browse the repository at this point in the history

  18. Fix container name.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c67c5b6 View commit details
    Browse the repository at this point in the history

  19. Don't modify package.json. 

    Run tests in phpunit-test.yml instead.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    9575fc7 View commit details
    Browse the repository at this point in the history

  20. Don't install composer dependencies twice.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4d6bdd4 View commit details
    Browse the repository at this point in the history

  21. Need to prefix commands with npm run.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    461200f View commit details
    Browse the repository at this point in the history

  22. Add double dashes to pass flags to wp-env.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    b299003 View commit details
    Browse the repository at this point in the history

  23. Fix name of the environment.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d722186 View commit details
    Browse the repository at this point in the history

  24. Add additional debug information.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    8c774d0 View commit details
    Browse the repository at this point in the history

  25. Composer dependencies should be installed after wp-env is intialised.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4319bac View commit details
    Browse the repository at this point in the history

  26. Fix wrong command.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    b245bc6 View commit details
    Browse the repository at this point in the history

  27. Since the tests are currently run within the Docker containers where … 

    …the PHP version varies, the same PHP version needs to be configured for the action runner.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    6057268 View commit details
    Browse the repository at this point in the history

  28. Fix path to the multisite.xml.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f8173c6 View commit details
    Browse the repository at this point in the history

  29. Fix the test class to be compatible with PHP < 7.3.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    0b8dff9 View commit details
    Browse the repository at this point in the history

  30. Fix bug in WP_REST_Block_Pattern_Categories_Controller_Test::wpTearDo… 

    …wnAfterClass.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    2fbdcc4 View commit details
    Browse the repository at this point in the history

  31. Remove incompatible PHP packages.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    76fcd32 View commit details
    Browse the repository at this point in the history

  32. Remove incompatible PHP packages.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    82745d8 View commit details
    Browse the repository at this point in the history

  33. Update description.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    db2044e View commit details
    Browse the repository at this point in the history

  34. Remove incompatible PHP packages.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    460da7c View commit details
    Browse the repository at this point in the history

  35. Remove incompatible PHP packages.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    1f607b5 View commit details
    Browse the repository at this point in the history

  36. Fix wrong matrix value.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d90b2fc View commit details
    Browse the repository at this point in the history

  37. Remove incompatible PHP packages.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    61a096f View commit details
    Browse the repository at this point in the history

  38. Don't remove polyfills.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    8232cd1 View commit details
    Browse the repository at this point in the history

  39. Don't remove spathie package on PHP 7.2.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    5dfa520 View commit details
    Browse the repository at this point in the history

  40. // strpos() doesn't support negative offset values on PHP prior to ve… 

    …rsion 7.1.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    bc9af74 View commit details
    Browse the repository at this point in the history

  41. Add cliPhpVersion config parameter.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    185f26a View commit details
    Browse the repository at this point in the history

  42. Don't use custom commands to run the tests.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    118286f View commit details
    Browse the repository at this point in the history

  43. Revert "Add cliPhpVersion config parameter." 

    This reverts commit 1a73cd9.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    7abd2c3 View commit details
    Browse the repository at this point in the history

  44. Don't use the phpunit docker-compose service.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    a6d2aee View commit details
    Browse the repository at this point in the history

  45. Fix dynamic properties. PHP 8.2 doesn't support dynamic properties.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    5890fb6 View commit details
    Browse the repository at this point in the history

  46. Fix dynamic properties. PHP 8.2 doesn't support dynamic properties.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    be706c6 View commit details
    Browse the repository at this point in the history

  47. Fix dynamic properties. PHP 8.2 doesn't support dynamic properties.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d44e9fa View commit details
    Browse the repository at this point in the history

  48. Allow /.cache/.gitkeep files.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    780e12e View commit details
    Browse the repository at this point in the history

  49. Add the .gitkeep file. 

    The .cache directory is needed for CI/build tools.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    1cbe0ee View commit details
    Browse the repository at this point in the history

  50. Add PHP Coding Stadnards.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f1cb171 View commit details
    Browse the repository at this point in the history

  51. Fix the if condition.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    2d5e7f0 View commit details
    Browse the repository at this point in the history

  52. Fix path.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    1636e2d View commit details
    Browse the repository at this point in the history

  53. Rename Core to Gutenberg.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f9dfc91 View commit details
    Browse the repository at this point in the history

  54. Add job's description.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    10e5d0f View commit details
    Browse the repository at this point in the history

  55. Add a comment to explain why we need the /.cache folder.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    31d5f22 View commit details
    Browse the repository at this point in the history

  56. Add a comment to explain why we need complicated .gitignore rules.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    5c92300 View commit details
    Browse the repository at this point in the history

  57. Fix grammar.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c16e8e5 View commit details
    Browse the repository at this point in the history

  58. Revert accidental changes.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    9ac9073 View commit details
    Browse the repository at this point in the history

  59. Revert accidental changes.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    1b0d068 View commit details
    Browse the repository at this point in the history

  60. Allow manually triggering the workflows. 

    Props to @jrfnl for suggesting it.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    bb0f4b7 View commit details
    Browse the repository at this point in the history

  61. Remove description.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    3c90728 View commit details
    Browse the repository at this point in the history

  62. Let's not limit the job by path.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    220bf63 View commit details
    Browse the repository at this point in the history

  63. PHP 7.3 and 7.4 should use PHPUnit 9. 

    Props to @jrfnl for finding this bug.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    6f158a7 View commit details
    Browse the repository at this point in the history

  64. Update the changelog. 

    Props to @jrfnl for identifying an issue with PHP 7.4 and 7.4.

# Conflicts:
#	packages/env/CHANGELOG.md
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    76a5d0e View commit details
    Browse the repository at this point in the history

  65. 1. Fix yaml synthax. 

    2. Don't put the OS version in the matrix.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c1bf302 View commit details
    Browse the repository at this point in the history

  66. In most repos, the convention is to have the if: above the run:. 

     Props to @jrfnl.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    9c91766 View commit details
    Browse the repository at this point in the history

  67. Don't log the PHP version; this information is available in the "Set … 

    …up PHP" step.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    571f5ee View commit details
    Browse the repository at this point in the history

  68. Don't log the Composer version; this information is available in the … 

    …"Set up PHP" step.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    a4c17e4 View commit details
    Browse the repository at this point in the history

  69. 1. Don't scan the unit tests twice. 

    2. Move the cache option to the phpcs.xml.dist
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    8b7348b View commit details
    Browse the repository at this point in the history

  70. Fix the cs2pr report location.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c46a898 View commit details
    Browse the repository at this point in the history

  71. Update the .gitignore rule description.

    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    2be51c6 View commit details
    Browse the repository at this point in the history

  72. Enable fast failing to save Github resources as proposed here: https:… 

    …//github.com/WordPress/gutenberg/pull/46510/files#r1055900997
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    ac99768 View commit details
    Browse the repository at this point in the history

  73. As the separate PHPCS run for the tests has been removed, this step s… 

    …hould be removed as well.

Props to @jrfnl.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    22bffeb View commit details
    Browse the repository at this point in the history

  74. Use the development php.ini file (to make any errors more obvious). 

    Props to @jrfnl.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    7cfdaae View commit details
    Browse the repository at this point in the history

  75. Use the development php.ini file (to make any errors more obvious). 

    Props to @jrfnl.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    8546c9c View commit details
    Browse the repository at this point in the history

  76. Revert "Use the development php.ini file (to make any errors more obv… 

    …ious)."

This reverts commit eaef3343f85faa8f50f7465eb70105cac961d0ca.
    @anton-vlasenko
    anton-vlasenko committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    9d0a477 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Move the unit tests to unit-test.yml. 

    This is needed because:
1. unit-php job has to be preserved as it's set as required in the GH settings.
2. unit-php job now depends on the test-php job.
    @anton-vlasenko
    anton-vlasenko committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    2a371d8 View commit details
    Browse the repository at this point in the history

  2. Change the description.

    @anton-vlasenko
    anton-vlasenko committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    8eb3280 View commit details
    Browse the repository at this point in the history

  3. Rename the job.

    @anton-vlasenko
    anton-vlasenko committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    017ce16 View commit details
    Browse the repository at this point in the history