Universal block inspector controls back button #46058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
getdave
changed the title
|
Size Change: +35 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
alexstine
reviewed
Nov 25, 2022
| onClick={ () => | ||
| selectBlock( closestControllingBlock?.clientId ) | ||
| } | ||
| label={ __( 'Go to controlling block' ) } |
There was a problem hiding this comment.
Please make this label more explanatory. Example: label={ sprintf( __( 'Back to parent block: %s', parentBlock.title ) ) }
32 tasks
getdave
commented
Dec 5, 2022
Comment on lines
+68
to
+69
| closestControllingBlock?.name !== 'core/template-part' && | ||
| closestControllingBlock?.name !== 'core/block'; |
There was a problem hiding this comment.
These values could come from block editor settings?
|
I'm not sure this PR is needed anymore so I"m closing it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #46037 (comment) we modified the back button in the inspextor controls so that it selects the closest parent Navigatino block.
This PR tries to make that solution universal to all block types outside of the experiment by seeking the first parent block that is controlling inner blocks and selecting that.
Why?
How?
Testing Instructions
Screenshots or screencast