Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patterns]: Update pattern category descriptions #46005

Merged
merged 2 commits into from
Nov 23, 2022
Merged

[Patterns]: Update pattern category descriptions #46005

merged 2 commits into from
Nov 23, 2022

Conversation

ntsekouras
Copy link
Contributor

What?

Extracted from: #45548

Implements category descriptions suggested by @beafialho in #44501 (comment), as a starting point

@ntsekouras ntsekouras added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Nov 23, 2022
@ntsekouras ntsekouras self-assigned this Nov 23, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 23, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Mamaduka
Mamaduka approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, a straightforward change.

I left one note regarding the text copy, where I would appreciate a second opinion.

lib/compat/wordpress-6.2/block-patterns.php Outdated Show resolved Hide resolved
@ntsekouras ntsekouras force-pushed the update/block-pattern-categories-descriptions branch from 00715aa to dd3ce47 Compare November 23, 2022 15:17
@ntsekouras ntsekouras enabled auto-merge (squash) November 23, 2022 15:19
@ntsekouras ntsekouras merged commit affc1e5 into trunk Nov 23, 2022
@ntsekouras ntsekouras deleted the update/block-pattern-categories-descriptions branch November 23, 2022 15:42
@github-actions github-actions bot added this to the Gutenberg 14.7 milestone Nov 23, 2022
@DaisyOlsen DaisyOlsen added the [Type] Enhancement A suggestion for improvement. label Nov 30, 2022
@annezazu annezazu mentioned this pull request Dec 5, 2022
Closed
57 tasks
@Mamaduka Mamaduka mentioned this pull request Jan 17, 2023
Closed
85 tasks
@youknowriad youknowriad mentioned this pull request Jan 17, 2023
Closed
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jan 30, 2023
@annezazu annezazu mentioned this pull request Feb 1, 2023
Closed
@femkreations femkreations mentioned this pull request Mar 2, 2023
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@jasmussen jasmussen Awaiting requested review from jasmussen

@beafialho beafialho Awaiting requested review from beafialho

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@ntsekouras ntsekouras

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ntsekouras @Mamaduka @jasmussen @DaisyOlsen @femkreations