Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberControl: tidy up and fix types around value prop #45982

Open
wants to merge 17 commits into
base: trunk
Choose a base branch
from
Open

NumberControl: tidy up and fix types around value prop #45982

wants to merge 17 commits into from
+242 −78

Commits on Jan 16, 2023

  1. Use optional chaining instead of noop

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    6700c80 View commit details
    Browse the repository at this point in the history

  2. Remove untrue return value explanations from ensureNumber and `ensu… 

    …reString` functions
    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    8f8c5ca View commit details
    Browse the repository at this point in the history

  3. Extract computeStep utility

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    1a3cb9c View commit details
    Browse the repository at this point in the history

  4. Fix action/payload type errors in reducer

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    1282d27 View commit details
    Browse the repository at this point in the history

  5. Extract shiftStepAsANumber

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    cfe7f1d View commit details
    Browse the repository at this point in the history

  6. Start passing the string version of value around the component

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    5c1f979 View commit details
    Browse the repository at this point in the history

  7. Make constrainValue and spinValue only deal with numbers, move "e… 

    …mpty check" before calls to these functions, wrap results in "ensureString"
    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    6b427ed View commit details
    Browse the repository at this point in the history

  8. Handle undefined value for DRAG/COMMIT/ENTER actions

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    ab442dd View commit details
    Browse the repository at this point in the history

  9. Add temporary uncontrolled storybook example

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    5f4b612 View commit details
    Browse the repository at this point in the history

  10. Typo

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    f5a3978 View commit details
    Browse the repository at this point in the history

  11. Move spinValue and constrainValue to utils file

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    f7822d2 View commit details
    Browse the repository at this point in the history

  12. Better TODO comment

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    5c45bff View commit details
    Browse the repository at this point in the history

  13. Add unit tests for ensureNumber and ensureString

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    a57be10 View commit details
    Browse the repository at this point in the history

  14. CHANGELOG

    @ciampo
    ciampo committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    41c3345 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Change ensureNumber and ensureString to return null when handling n… 

    …on-finite numbers
    @ciampo
    ciampo committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    1da7361 View commit details
    Browse the repository at this point in the history

  2. Typo

    @ciampo
    ciampo committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    3ac25c9 View commit details
    Browse the repository at this point in the history

  3. Move constrainValue and spinValue back to main index file

    @ciampo
    ciampo committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    bc58827 View commit details
    Browse the repository at this point in the history