Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative: add inserter to Nav block offcanvas experiment #45947

Merged
merged 8 commits into from
Nov 23, 2022
Merged

Alternative: add inserter to Nav block offcanvas experiment #45947

merged 8 commits into from
Nov 23, 2022

Commits on Nov 23, 2022

  1. Include offcanvas specific styles

    @getdave
    getdave committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    42c036e View commit details
    Browse the repository at this point in the history

  2. Use standard Inserter only

    @getdave
    getdave committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    e2b9206 View commit details
    Browse the repository at this point in the history

  3. Avoid using underscore naming convention

    @getdave
    getdave committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    a9931d7 View commit details
    Browse the repository at this point in the history

  4. Use standard UI components for keyboard navigation

    @getdave
    getdave committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    3c00dc5 View commit details
    Browse the repository at this point in the history

  5. Extract appender to file

    @getdave
    getdave committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    1a3b041 View commit details
    Browse the repository at this point in the history

  6. Apply TreeGridRow props

    @getdave
    getdave committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    2ad866f View commit details
    Browse the repository at this point in the history

  7. Remove clientId prop drilling

    @getdave
    getdave committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    c267917 View commit details
    Browse the repository at this point in the history

  8. Remove need to pass clientID to offcanvas component

    @getdave
    getdave committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    ef38df3 View commit details
    Browse the repository at this point in the history