Add block appender to Nav block offcanvas experiment #45905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Block] Navigation
|
|
|
Size Change: +268 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
getdave
changed the title
getdave
reviewed
Nov 21, 2022
| @@ -67,6 +67,7 @@ function ButtonBlockAppender( | |||
| <VisuallyHidden as="span">{ label }</VisuallyHidden> | |||
| ) } | |||
| <Icon icon={ plus } /> | |||
| { children } | |||
There was a problem hiding this comment.
This may need to be a separate PR. Basically it allows us to do this
<ButtonBlockAppender
className="offcanvas-editor__list-appender__toggle"
rootClientId={ rootClientId }
>
{ __( 'Add Menu Item' ) }
</ButtonBlockAppender>
Otherwise we're going to have to reimplement all of <ButtonBlockAppender> as a custom component. Possible but will require additional time.
getdave
reviewed
Nov 21, 2022
Comment on lines
-107
to
+111
| ( event, clientId ) => { | ||
| updateBlockSelection( event, clientId ); | ||
| setSelectedTreeId( clientId ); | ||
| ( event, _clientId ) => { |
There was a problem hiding this comment.
These changes to clientID were to appease the linter which was telling me it was shadowing an existing var.
getdave
reviewed
Nov 21, 2022
| /> | ||
| </ListViewContext.Provider> | ||
| </TreeGrid> | ||
| <div className="offcanvas-editor"> |
getdave
reviewed
Nov 21, 2022
Comment on lines
+222
to
+224
| <OffCanvasEditorAppender | ||
| rootClientId={ clientId } | ||
| /> |
There was a problem hiding this comment.
The internal implementation of BlockListAppender doesn't pass the rootClientId to the CustomComponent provided by renderAppender. So we have to manually do it here.
getdave
reviewed
Nov 21, 2022
Comment on lines
+217
to
+218
| <tr> | ||
| <BlockListAppender |
There was a problem hiding this comment.
I noticed from an a11y POV the arrow key navigation will not focus this element. I think that's probably legit as it's not a "block" per se but FYI.
getdave
reviewed
Nov 21, 2022
| className="offcanvas-editor__list-appender__toggle" | ||
| rootClientId={ rootClientId } | ||
| > | ||
| { __( 'Add Menu Item' ) } |
There was a problem hiding this comment.
Annoyingly the internal implementation of ButtonBlockAppender doesn't allow us to customise the label. So we have one text based label here and another provided by ButtonBlockAppender.
|
See alternative over at #45947 |
|
Closing in favour of #45947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a basic appender to the Offcanvas Nav block experiment.
This does not fully implement the appender. Further work is required to customise the appender to show the UI in the sidebar rather than on the canvas.
Consider also comparing this with #45947.
Part of #45445.
Co-authored-by: Dave Smith getdavemail@gmail.com
Why?
Addresses the first part of #45445.
How?
Adds a custom appender to the list view sidebar.
Testing Instructions
Screenshots or screencast
Screen.Capture.on.2022-11-21.at.14-23-54.mp4