Adds a list view to the navigation block #45521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
spacedmonkey,
ellatrix and
tellthemachines
as code owners
|
|
draganescu
added
[Type] Enhancement
draganescu
changed the base branch from
trunk
to
add/experimental-duplicate-of-list-view
draganescu
changed the base branch from
add/experimental-duplicate-of-list-view
to
trunk
draganescu
changed the base branch from
trunk
to
add/experimental-duplicate-of-list-view
|
Size Change: +263 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
add/experimental-duplicate-of-list-view
branch
2 times, most recently
from
b791c55
to
3c5d618
Compare
draganescu
force-pushed
the
add/list-view-to-navigation-block
branch
from
33a719c
to
e4dc96d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a spin off from #44534.
It uses the experimental off canvas editor which is a simple copy of list view to manage items in the navigation menu. For
now the items can only be basically reordered.
Why?
To allow better management of the items in the navigation block using a birds eye tree view.
How?
Adding a copy of the experimental off canvas editor (copied listview) to the block's inspector.
Adding a new prop to off canvas editor (which list view does not have) to turn off block selection on clicking list view
blocks.
Testing Instructions
menu" experiment from Gutenberg > Experiments
Screenshots or screencast