TabPanel: Add tests and changelog for onSelect behavior change #45211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
chad1008
reviewed
Oct 24, 2022
| const user = setupUser(); | ||
| const mockOnSelect = jest.fn(); | ||
|
|
||
| const { rerender } = render( |
There was a problem hiding this comment.
TIL - this is a cool little destructure!
chad1008
approved these changes
Oct 24, 2022
|
Thanks for the follow-up here |
mirka
force-pushed
the
tabpanel-add-tests
branch
from
db98771
to
76fbf58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #44028
What?
Adds changelog and tests for a bug fix added in #44028.
Why?
This surfaced in a rebase while reviewing #44935. It's a notable change to what triggers the
onSelectcallback, and warrants a changelog for affected consumers.Testing Instructions
✅ Tests pass