[Experiment]: Try Openverse integration #44424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Inserter
ntsekouras
requested review from
mcsf,
youknowriad,
mtias,
jameskoster and
jasmussen
|
Size Change: +1.49 kB (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
This is incredible. Here's the inserter tab for Images working super well:
Outstanding! CC: @javierarce (AFK today, but here tomorrow) as I think he's worked on some mockups for this. We should put those on a ticket: A few quick ones:
Search is a bit of an open question, as ideally we can avoid having two search boxes in the inserter. This is something to think about as we move forward with this. |
|
Thank you for working on this @ntsekouras Nik! Testing. Twenty Twenty Two. Before
After
Clicking Explore. Blocks - Patterns - Reusable - Images. A Reusable block is really a pattern that is synced. So I believe that Reusable blocks should be in the Patterns tab. Having an area in the Patterns for synced patterns (Reusable blocks). (But that is a discussion for another issue.) Thanks for linking in Riad's PR, Joen! Regarding the External Images modul. This should in some way link in with the Media Library. So one can view internal and external images. This is getting close to redesigning the Media Library with better integration with the Block editor and Openverse. |
|
Niiice!! I like it! Lots of potential here ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Be prepared for really ugly code with no design at all, so please no code reviews 😄
This is just barely working POC I made today to start the discussions about an Openverse integration. I have just added some sections(multiple selection, etc..) with ideas I had about such an integration and many things might be missing or we can decide how we could do it iteratively.
I'll update the PR later to have some more info, but you can see an
Imagestab in the main inserter with anExplorebutton similar to the patterns.Only a few notes for now
Screenshots or screencast
Screen.Recording.2022-09-23.at.8.15.02.PM.mov
Video for another reason to have the selected blocks separately
Screen.Recording.2022-09-23.at.8.42.25.PM.mov