Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Links: Enable alpha on color pickers #43453

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Social Links: Enable alpha on color pickers #43453

merged 1 commit into from
Aug 22, 2022

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 21, 2022

Related:

What?

Enable alpha in the color pickers used in the Social Links (Icons) block.

Why?

To create consistency in the color pickers across blocks.

How?

Add enableAlpha to the PanelColorSettings used in the block.

Testing Instructions

  1. Add a Social Icons block to a new page.
  2. Add a few icons.
  3. Change the color of the icon and/or background.
  4. See that you can now change the transparency (alpha channel) on the colors.

Screenshots or screencast

Before:
image

After:
image

@ndiego ndiego requested a review from ajitbohra as a code owner August 21, 2022 17:20
@ndiego ndiego self-assigned this Aug 21, 2022
@ndiego ndiego added [Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 21, 2022
aaronrobertshaw
aaronrobertshaw approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me.

✅ Icon color alpha channel works
✅ Icon background color alpha channel works
✅ Semi-transparent colors match in editor and frontend.

@aaronrobertshaw
Copy link
Contributor

I've kicked off the failing e2e again as the error looks unrelated (timeout). Once it passes, this should be right to merge.

@aaronrobertshaw aaronrobertshaw merged commit a7e263a into WordPress:trunk Aug 22, 2022
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 22, 2022
@ndiego
Copy link
Member Author

ndiego commented Aug 22, 2022

Thanks @aaronrobertshaw!

ramonjd added a commit that referenced this pull request Aug 23, 2022
@ramonjd
Disable contrast checker for the background color
b2dfb82 
Enable alpha for icons and icon background colors added in #43453
@ramonjd ramonjd mentioned this pull request Aug 23, 2022
Merged
ramonjd added a commit that referenced this pull request Aug 24, 2022
@ramonjd
Social links: add background color block supports (#43293)
a79329b 
* Adding background color block supports to the social links block.

* Adding background color block supports to the social links block.

* Revert emptytheme theme.json

* Disable contrast checker for the background color
Enable alpha for icons and icon background colors added in #43453
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
@femkreations femkreations mentioned this pull request Oct 5, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronrobertshaw aaronrobertshaw aaronrobertshaw approved these changes

@ramonjd ramonjd Awaiting requested review from ramonjd

@carolinan carolinan Awaiting requested review from carolinan

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@ndiego ndiego

Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ndiego @aaronrobertshaw @femkreations