Card: migrate to TypeScript #42941
Merged
Card: migrate to TypeScript #42941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
added
[Package] Components
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
ciampo
reviewed
Aug 8, 2022
There was a problem hiding this comment.
Hey @torounit , thank you for working on this!
On top of the inline comments, here's some additional feedback:
- Should we add a wrapper around the
Cardin the Storybook example? - Currently, Storybook is not showing controls and documentation for the subcomponents — how can we fix that ? (cc @mirka )
- Can we also refactor the unit tests to TypeScript?
Thank you!
Hmm, the subcomponents are showing for me. Maybe yours needed a cold restart? CleanShot.2022-08-09.at.21.47.37.mp4(Subcomponents don't support controls, btw, so only the docs will show) |
|
Ah! It took me a while to find them! Kapture.2022-08-10.at.16.48.28.mp4
That's unfortunate. Hopefully support will be added soon |
torounit
force-pushed
the
refactor/ts-card
branch
from
50293d1
to
453dfd0
Compare
|
Sorry for the late reply, thanks for the review.
|
ciampo
reviewed
Aug 19, 2022
|
This PR may need a rebase to pass CI tests |
Ah, and a CHANGELOG entry (the "internal" section is ok) |
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
torounit
force-pushed
the
refactor/ts-card
branch
from
4178bf0
to
63b8b06
Compare
ciampo
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #35744
Converts the
Cardcomponent to TypeScript.Testing Instructions
npm run storybook:devCard