InputControl: Fix incorrect size prop passing to Text
#42793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the erroneous passing down of a
sizeprop, which was resulting in invalid CSS likefont-size: default.There are no visual changes, because that invalid
font-sizevalue was being overridden anyway in the CSS cascade.Why?
Clean up.
How?
This bug has been there since the inception of InputControl (#22329). This PR is a simple fix — bug error prevention measures will be discussed separately in #42792.
Testing Instructions
npm run storybook:devfont-size: defaultaren't being emitted.