Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Convert Block Type test to Playwright #42760

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Migrate Convert Block Type test to Playwright #42760

merged 3 commits into from
Jul 28, 2022

Conversation

pooja-muchandikar
Copy link
Contributor

What?

Part of #38851.
Migrate convert-block-type.test.js to its Playwright version.

Why?

Part of #38851.

How?

See MIGRATION.md for migration steps.

Testing Instructions

Run npm run test-e2e:playwright test/e2e/specs/editor/various/convert-block-type.spec.js

@pooja-muchandikar
Copy link
Contributor Author

Hi @kevin940726, @talldan 👋

I hope you are doing great!

I have raised another migration PR, please could anyone of you help me in reviewing this PR?

Thanks!!

kevin940726
kevin940726 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left some nitpicks but they're optional, I think this looks good!

test/e2e/specs/editor/various/convert-block-type.spec.js Outdated Show resolved Hide resolved
test/e2e/specs/editor/various/convert-block-type.spec.js Outdated Show resolved Hide resolved
test/e2e/specs/editor/various/convert-block-type.spec.js Show resolved Hide resolved
@pooja-muchandikar
Copy link
Contributor Author

Hi @kevin940726,

I have addressed all the feedbacks please could you check once?

@kevin940726 kevin940726 merged commit ed5813c into WordPress:trunk Jul 28, 2022
@kevin940726
Copy link
Member

Awesome work! Thanks!

@github-actions github-actions bot added this to the Gutenberg 13.9 milestone Jul 28, 2022
@pooja-muchandikar
Copy link
Contributor Author

Hi @kevin940726,

Looks like the PR details are not added here- #38851

@pooja-muchandikar pooja-muchandikar deleted the add/playwright-convert-block-type-test branch July 28, 2022 12:56
@kevin940726 kevin940726 mentioned this pull request Jul 29, 2022
Closed
@kevin940726
Copy link
Member

Added! Thanks for letting me know!

@oandregal oandregal added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Aug 10, 2022
@oandregal
Copy link
Member

Added label for the changelog.

@yaseenaljamal yaseenaljamal mentioned this pull request Jan 31, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 31, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 1, 2024
Open
@yassine4999 yassine4999 mentioned this pull request Feb 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin940726 kevin940726 kevin940726 approved these changes

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 13.9
Development

Successfully merging this pull request may close these issues.
3 participants
@pooja-muchandikar @kevin940726 @oandregal