Abbreviate post schedule date when possible #41738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use abbreviations such as 'Today' and 'Tomorrow' in the post schedule label when it makes sense to do so.
noisysocks
added
[Type] Enhancement
|
Not sure why the text in the post schedule button wraps to a new line on hover. Will investigate tomorrow. |
|
Size Change: +827 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
Except for the thing that you mentioned (could it be related to the tooltip?), this works fine for me.
This is great, I'll add the last exceptions to the Figma file. |
|
Cool improvement! |
OK, I've added a hacky fix for this along with an explanatory comment. When #41268 is merged we should be able to remove the hack. |
andrewserong
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Nice work @noisysocks, this is testing well (and I like the small addition of the non-breaking space between the minutes and AM / PM 👍)
✅ With a different user timezone to site timezone, the full date is displayed consistently
✅ With a matching timezone, Today behaves correctly
✅ With a matching timezone, Tomorrow behaves correctly
✅ With a matching timezone, the current year is hidden if the publish date is this year
✅ With a matching timezone, the current year is displayed if the publish date is next year
✅ Tooltip popover styling hack works in the interim 👍
LGTM! ✨
|
Thanks @andrewserong and @javierarce! |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use abbreviations such as 'Today' and 'Tomorrow' in the post schedule label when it makes sense to do so.
Why?
Part of #39082. Specifically, this page in the Figma:
How?
I added a bunch of if statements to
PostScheduleLabel! 😀I followed what's outlined in the design above pretty closely, except for:
If the user's timezone does not match the site's timezone, then we always show the full date. This avoids ambiguity around what e.g. 'tomorrow' means when the timezones are different.
If the site's timezone has a name (e.g. 'AEST') then we show that instead of the UTC offset (e.g. 'UTC+10'). This is what we do in the date picker.
All of the date formats are passed through
_xso that they can be localised.I switched to using
wp.date.dateI18n(instead ofwp.date.format) so that any words in the dates (e.g. 'Monday') can be localised.Testing Instructions
Screenshots or screencast
Kapture.2022-06-15.at.17.07.10.mp4