Add featured image to image block #41704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +186 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
|
I don't think this makes a lot of sense right now, we have the transform to the featured image block itself, and the placeholder is nicer. |
|
@mtias I think we should at least add the workflow of "image to featured image", maybe via what #41722 introduces? Also, " we have the transform to the featured image block itself",
Should it not appear there? Discussing this PR here with @scruffian it came up that maybe the featured image should be a variation of the image block anyway. |
One advantage of this approach is that we get all the extra affordances of the image block for the featured image block. We would also have one less block to maintain. |
|
Possibly, but the UX we achieved with the Cover block is still not that great. We should try to get the original proposed design (with the toggle in the dropdown) working before adopting it beyond. |
@mtias we did move on on that front, what is left is improving the look, but that is a thing on its own how active drop down menus look everywhere, yet the toggle toggles 😁 drop-down-toggle.mp4 |
|
We need #38990 before we can progress this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the posibility to use the post featured image to the image block.
I am unclear on the value of this given the existing of a featured image
block.
Why?
To make featured image one of the sources of the image block.
How?
Adds the code to handle feature image so that the media replace flow
component enables the toggle.
Testing Instructions
Screenshots or screencast