jest-console: Add types directory to "files" #41386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `types` directory won't get published to npm if we don't tell npm to include it!
noisysocks
added
[Type] Bug
noisysocks
requested review from
gziolo,
ntwb,
nerrad and
ajitbohra
as code owners
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
The `types` directory won't get published to npm if we don't tell npm to include it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Includes the
typesdirectory in the list of files that are published to npm.Why?
So that third parties can see the TypeScript definitions included in
jest-console. Right now nothing appears:https://unpkg.com/browse/@wordpress/jest-console@5.1.0/
How?
Testing Instructions
Screenshots or screencast