Migrate revert template test to Playwright #41310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
kevin940726,
JustinyAhin,
noisysocks and
apeatling
tellthemachines
added
the
[Type] Automated Testing
|
Size Change: +269 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
May 27, 2022
kevin940726
reviewed
May 31, 2022
kevin940726
approved these changes
May 31, 2022
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
JustinyAhin
approved these changes
May 31, 2022
Co-authored-by: Kai Hao <kevin830726@gmail.com>
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
* Migrate revert template test to Playwright * Improve selectors. * Address review feedback. * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Update test/e2e/specs/site-editor/template-revert.spec.js Co-authored-by: Kai Hao <kevin830726@gmail.com> * Address PR feedback. Co-authored-by: Kai Hao <kevin830726@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851. Migrate and refactor
template-revert.test.jsto Playwright. This suite has some known flaky tests so hopefully the migration fixes #36677 and #36672.Why?
See this post for an overview of the migration.
How?
By following the migration guide.
Testing Instructions
npm run test-e2e:playwright -- test/e2e/specs/site-editor/template-revert.spec.js
Screenshots or screencast