Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: Fix positioning by anchoring to child element #41268

Merged
merged 17 commits into from
Jul 19, 2022
Merged

Tooltip: Fix positioning by anchoring to child element #41268

merged 17 commits into from
Jul 19, 2022

Commits on Jul 13, 2022

  1. ToolTip: Fix positioning by anchoring to child element

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    feb14f2 View commit details
    Browse the repository at this point in the history

  2. Fix left/right issue

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    7e7715c View commit details
    Browse the repository at this point in the history

  3. Switch post schedule and post visiblity to 'bottom right' for consist… 

    …ency
    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a52ee64 View commit details
    Browse the repository at this point in the history

  4. Move left/right transformation to the ToolTip component

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a546fda View commit details
    Browse the repository at this point in the history

  5. Switch back to functions, fix tests

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    c700826 View commit details
    Browse the repository at this point in the history

  6. Tidy up

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    ec06c72 View commit details
    Browse the repository at this point in the history

  7. Add changelog entry

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a57bc9d View commit details
    Browse the repository at this point in the history

  8. Center Tooltip to the appropriate placement point

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    338b2aa View commit details
    Browse the repository at this point in the history

  9. Attempt to simplify the implementation

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    c09a8b2 View commit details
    Browse the repository at this point in the history

  10. Revert change to test

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a0ba72d View commit details
    Browse the repository at this point in the history

  11. Revert default back to middle position

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    6fc7d73 View commit details
    Browse the repository at this point in the history

  12. Fix error with getDisabledElement

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    5131ea8 View commit details
    Browse the repository at this point in the history

  13. Move ref in disabled element to the cloned child element

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    b903d19 View commit details
    Browse the repository at this point in the history

  14. Update Storybook example with a small target to better demonstrate po… 

    …sitioning issues
    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4f67e5b View commit details
    Browse the repository at this point in the history

  15. Simplify Tooltip story slightly

    @andrewserong
    andrewserong committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    9454226 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Consolidate child const for both uses

    @andrewserong
    andrewserong committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    90f5541 View commit details
    Browse the repository at this point in the history

  2. Revert previous change, but add a named const for the existing child … 

    …ref for clarity
    @andrewserong
    andrewserong committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    88f9e6c View commit details
    Browse the repository at this point in the history