Revert renaming of useEntityId hook #39683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
draganescu,
adamziel,
youknowriad,
gziolo and
dmsnell
This was referenced Mar 23, 2022
|
Riad makes good point here - #39681 (comment), so reverting the change makes sense to me. |
|
Size Change: -3 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
This was referenced Mar 23, 2022
getdave
force-pushed
the
fix/revert-rename-of-use-entity-id-hook
branch
from
7a538ac
to
87dfc42
Compare
|
I've rebased this in the hope that it will get the RN tests to run. @draganescu please feel free to merge when it's green. |
|
Looks to be failing due to #39689. Will need to merge that one and rebase this one to get the e2e tests to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #39681.
This PR reverts the renaming of
useEntityIdback to the original.Why?
This hook is part of the public API of
@wordpress/core-databut it has been removed in favour ofuseEntityProviderIdwithout the formal deprecation process.This was caught as part of a fix to the Navigation block which broke when the hook was removed.
It has been suggested that renaming to include the "provider" term exposes implementation details to the consumer.
As the folks who worked on the original PR aren't available right now, it was deemed the simplest option simply to revert the rename of this one hook for now. @adamziel can always resubmit a PR to rename again later.
How?
This PR takes the approach suggested by @youknowriad in #39681 (comment) which is simply to rename the hook back to the original.
Testing Instructions
Start emptyAdvancedpanel of block's Inspector controlstrunkit crashes)Screenshots or screencast