Add tests for Editable.adaptFormatter() #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BE-Webdesign
added
the
[Type] Automated Testing
|
I have one concern here. This test covers private function from the component. There was usually a rule to test only public API in the previous projects, I worked with. Do you think we should keep the same rule in Gutenberg? We can always move that method to the file with utilities when we fill that it deserves its own tests. |
|
If we are fine with testing private methods, then it's good to go 👍 |
|
One option is if these private methods are used somewhere in a public facing code we can get coverage that way. For now going to leave the PR open. |
gziolo
reviewed
Dec 15, 2017
blocks/editable/test/index.js
Outdated
| test( 'should return an object on inline: span, and a styles property matching the style object provided', () => { | ||
| expect( wrapper.instance().adaptFormatter( options ) ).toEqual( { | ||
| inline: 'span', | ||
| styles: { ...options.style }, |
There was a problem hiding this comment.
It can also simply styles: options.style,. No need to clone it.
There was a problem hiding this comment.
Sometimes I do silly things 🙃
gziolo
approved these changes
Dec 15, 2017
BE-Webdesign
force-pushed
the
add/test/editable/adapt-formatter
branch
from
ebe5f53
to
2f27d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for Editable.adaptFormatter()