Try: Remove iframe 100% width rule. #38614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
CSS Styling
|
Size Change: -17 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
|
Not at all urgent, but in case you have a cycle to take a look, @MaggieCabrera, I'd love your eyes on this one. If the suggestion is "let's keep it", I'm totally fine with that as well. |
|
I've been looking at the back and forth with this rule and overall it seems like the right to go about this is removing it. There's certainly the main issue where frontend and editor don't match, which alone is enough to justify this PR. I've tested the following on a block theme without extra CSS: And they work as expected with this PR. The embed block already has a |
MaggieCabrera
approved these changes
Apr 4, 2022
|
Thank you, those are excellent thoughts. I agree just syncing up editor and frontend is enough justification. I'll land this and be vigilant about any followups we need to make, including outputting this rule also on the frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #38586.
The following rule is output in the post editor canvas, but not in the site editor canvas:
As discussed in the ticket above, it's creating an inconsistency where it appears to be contained in editor, but not on the frontend. This PR removes the rule, bringing consistency between post editor and frontend, but also post editor and site editor.
Note: this exact same rule was removed in the past as well, in #18240, and then added back again in #18287. Before merging this one, it's worth finding out exactly why it was added back again.
Testing Instructions
Checklist:
*.native.jsfiles for terms that need renaming or removal).