Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector Controls: add custom slot group after core slot #38215

Closed
wants to merge 1 commit into from
Closed

Inspector Controls: add custom slot group after core slot #38215

wants to merge 1 commit into from

Conversation

t-hamano
Copy link
Contributor

See: #37845

This pull request will provide a new group to the InspectorControls slot, allowing controls to be added after the typography / dimensions /border.

Currently, it is possible to inject any InspectorControls using the editor.BlockEdit filter.
However, the injected position is fixed to before typegraphy slot.

So if you inject an InspectorControl in custom block with multiple supports, the control will be inserted between the Color panel and the Typography panel.

I think that it is unnatural for a custom control to be interrupted between the panels provided by the core.

I think there needs to be a receptacle at the end of all the core controls, just before the advanced controls, where any InspectorControls can be injected.

The name of the group I added is "bottom", but there may be a better name.

Please let me know what you think about this pull request.

@gziolo gziolo added [Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Inspector Controls The interface showing block settings and the controls available for each block labels Jan 25, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Inspector Controls The interface showing block settings and the controls available for each block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants