-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility improvements for Block Inserter #37357
Merged
youknowriad
merged 17 commits into
WordPress:trunk
from
alexstine:try/accessibility-fixes-for-inserter
Jan 7, 2022
Merged
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
38868d5
Add Close button to Block Inserter. Adjust the useFocusOnMount hook t…
alexstine 83fb9e0
Make tests stable.
alexstine ab9bd8d
Remove CSS and use the viewport hook to toggle between visual button …
alexstine 5637346
Fix tests.
alexstine cc51c95
Toggle the tag type and save some code room.
alexstine 1dbdad0
Focus block inserter search form.
alexstine 7975ec1
Pass the open state to useEffect.
alexstine 76962cb
Use ref forwarding.
alexstine 701f930
Merge branch 'trunk' of https://github.com/wordpress/gutenberg into t…
alexstine 1afc148
Try to fix tests.
alexstine 9764c59
Revert package-lock.json changes.
alexstine 0d9fdf2
Fix tests.
alexstine 2a97df2
Fix tests.
alexstine 64f0b8f
Fix inserter input focus
youknowriad b975b40
Apply changes to edit-site/edit-widgets.
alexstine c4715a1
Formatting fixes.
alexstine ea055f1
Fix: Unable to close block inserter in Widgets view.
alexstine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to set this to null to prevent the useFocusOnMount hook from firing. Now that useEffect is being used, it would cause duplicate focus events.