Add copy pattern button to navigation block advanced inspector controls #36200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
|
Size Change: +238 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
|
This works well in my manual test. I had two reservations: The second is the name or copy of the button. Is it clear enough to users and developer what is being copied? |
|
Thanks for the feedback @carolinan.
Yep, agreed that it'd be better right at the bottom. I'll see if I can find a way to do that. Another idea is to put it in the block settings menu instead of the inspector panel, though it would need to be distinct from the other 'Copy' option there.
Yeah, I wasn't sure about this either. Markup is a better suggestion, and I'll have a think about alternatives. |
|
This technically works, but it seems weird to me, since it's a totally different flow for creating a pattern. I think it could use some additional design feedback. |
|
It seems to me this button only makes sense if you're copying one specific block (the Navigation block) in one specific way (from one site, to another site). As such, I don't think the button has that much use outside of a very select workflow. I think a button like this could make sense in the context of a "Pattern Editor," but in the post or site editor I don't think its necessary. |
|
I mostly worked on this to address the concern here - #35947 (comment) I would be absolutely fine with not shipping this, but want to acknowledge that it will leave anyone trying to create a pattern that incorporates the navigation block in a difficult position. Given that I work in the APAC region, there's likely going to be very little opportunity for me to reply to any further comments, so I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #35947
Recently the navigation block inner blocks became stored in a
wp_navigationpost that it references using an id. The markup looks like this:The id attribute is specific to a WordPress instance, so it can't be used in a pattern.
For back compat, the block does also support being defined in the old school way, and will migrate these inner blocks to a
wp_navigation:But a pattern creator can't create this kind of block markup, they'd have to type it out.
This PR adds 'Copy Pattern' button so that using a block that has markup like the first example, a pattern creator can copy markup that looks like the second example.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).