Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block spacing: add axial gap block support #35454

Closed
wants to merge 9 commits into from
Closed

Block spacing: add axial gap block support #35454

wants to merge 9 commits into from

Commits on Dec 9, 2021

  1. initial commit

    @ramonjd
    ramonjd committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    533b915 View commit details
    Browse the repository at this point in the history

  2. Don't ever merge this commit. Ever. What ever you do.

    @ramonjd
    ramonjd committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    803145b View commit details
    Browse the repository at this point in the history

  3. Forgot stuff

    @ramonjd
    ramonjd committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    a32c70f View commit details
    Browse the repository at this point in the history

  4. Remove var_dump YOLO

    @ramonjd
    ramonjd committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    e701016 View commit details
    Browse the repository at this point in the history

  5. Cleaning up. Using single row value where blockGap isn't split.

    @ramonjd
    ramonjd committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    7a04adb View commit details
    Browse the repository at this point in the history

  6. Cleaning up the regex, rebase for theme.json v2 

    updating php unit tests
adding axial tests
replacing block usages of block gap var with equivalent axial var

Update packages/block-library/src/button/style.scss

Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
    @ramonjd @andrewserong
    ramonjd and andrewserong committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    84b8bcd View commit details
    Browse the repository at this point in the history

  7. revert

    @ramonjd
    ramonjd committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    76fb0f9 View commit details
    Browse the repository at this point in the history

  8. Setting the margin-top value of blocks to the row value instead of th… 

    …e columns gap value.

Where the row and column values are the same, use a single value instead of shorthand in the block-gap CSS var.
    @ramonjd
    ramonjd committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    6f072c6 View commit details
    Browse the repository at this point in the history

  9. Updating tests

    @ramonjd
    ramonjd committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    a742255 View commit details
    Browse the repository at this point in the history