Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToolsPanel: Remove hardcoded classnames #35415

Merged
merged 9 commits into from
Oct 15, 2021
Merged

ToolsPanel: Remove hardcoded classnames #35415

merged 9 commits into from
Oct 15, 2021

Commits on Oct 14, 2021

  1. Remove reference to components-tools-panel class

    @aaronrobertshaw
    aaronrobertshaw committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    daf5885 View commit details
    Browse the repository at this point in the history

  2. Remove hardcoded references to components-base-control in styles

    @aaronrobertshaw
    aaronrobertshaw committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    1e4e918 View commit details
    Browse the repository at this point in the history

  3. Remove hardcoded dropdown classes from styles

    @aaronrobertshaw
    aaronrobertshaw committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    ba53bd2 View commit details
    Browse the repository at this point in the history

  4. Tweak selector for overriding BaseControl styles 

    The most common use of the base control within the ToolsPanel has it one level deeper. The cleanest option appears to be blanket removal of the margin when within a ToolsPanel, if the component using BaseControl is more complex it can override that style as needed.
    @aaronrobertshaw
    aaronrobertshaw committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    77ab9f0 View commit details
    Browse the repository at this point in the history

  5. Switch first-child to first-of-type

    @aaronrobertshaw
    aaronrobertshaw committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    355810f View commit details
    Browse the repository at this point in the history

  6. Reinstate the hardcoded classnames for targeting dropdown menu

    @aaronrobertshaw
    aaronrobertshaw committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    99a4572 View commit details
    Browse the repository at this point in the history

  7. Switch tools panel header to use HStack and Heading

    @aaronrobertshaw
    aaronrobertshaw committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    9439aaf View commit details
    Browse the repository at this point in the history

  8. Tweak panel header spacing

    @aaronrobertshaw
    aaronrobertshaw committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    d684a45 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Remove stale comment

    @aaronrobertshaw
    aaronrobertshaw committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    2112f8d View commit details
    Browse the repository at this point in the history