Enable iframe-inline-styles e2e test #35171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Sep 28, 2021
I did. Of course, I could only try it locally, but I've run it a dozen times since yesterday and there were no issues on my localhost. We could leave it unmerged for a couple of days... I'll be rebasing it (which will trigger tests) so we can get a better idea of whether this is now stable or not |
|
I've just restarted the e2e tests to try a second time. Maybe we can just merge if they pass 🤷♂️ |
|
The bot did catch some flaky results in #35172 though. Just FYI ;) |
|
There you go, that bot detects flakiness even before we merge :) |
|
So failures happened but we didn't know about them (we didn't check issues), makes me wonder if we can somehow disable the bot for new tests as otherwise we risk introducing too many unstable tests inadvertently. |
aristath
force-pushed
the
enable-iframed-inline-styles-tests
branch
from
6f4753b
to
4b9c8a6
Compare
|
All tests keep passing without any issues so I think this is safe to merge now 👍 |
|
Sadly, it's still flaky and failed once on trunk 😅. |
|
meh... Reverting then. Thank you for the quick response @kevin940726! 👍 |
|
Revert PR in #41369 |
youknowriad
pushed a commit
that referenced
this pull request
May 26, 2022
aristath
added a commit
that referenced
this pull request
May 27, 2022
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test was disabled in #33503
However, it now looks like the test is no longer that unstable so we could re-enable it.
cc @ellatrix @youknowriad
Checklist:
*.native.jsfiles for terms that need renaming or removal).