-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct inconsistencies and errors in Nav Editor docs #34682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this and updating it 🙇
@talldan Just noticed your 👍 here. I made some additional changes. Are you still happy? |
I haven't forgotten about this... |
The update looks great, Dave. The "Hooks" section is updated, but I can correct it in follow-up PR today/tomorrow. The new central hooks are |
As requested by #34682 (comment)
Seeking final ✅ on the basis that the scope of this PR is to
🙏 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is in good shape, and all feedback got addressed 🌟
I'll do a follow-up for hooks tomorrow.
Description
Following as discussion with @talldan I discovered that there are some inconsistencies in the Nav Editor docs. This PR corrects these. See individual commits for specifics.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).