Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue Forms: Simplify the bug report form template #34007

Merged
merged 8 commits into from
Aug 13, 2021

Conversation

priethor
Copy link
Contributor

@priethor priethor commented Aug 11, 2021

Description

Followup to #33713. The first iteration on using form templates directly translated the markdown template to a form template. However, markdown templates allow for users to easily delete parts of it and adjust it to the report, whereas with the form template the report needs to be adapted entirely to the form. This leads to:

  • When reporting, a long form that can't be tweaked and creates friction.
  • Once reported, long reports even when optional fields are left empty

Proposed changes

  • Grouped the pre-checks into a single group.
  • Moved the pre-checks to the bottom. Although being on top might help some users that are not aware of those recommendations, in general, it should be ok having them at the bottom similar to how checkboxes to "Accept terms" are at the bottom of forms. The main benefit, though, is avoiding having these checkboxes at the start of the bug report once submitted, where the most relevant information should be.
  • Grouped together description and steps to reproduce.
  • Grouped together expected vs actual behavior.
  • Grouped together screenshots and code snippets as extra resources.
  • Grouped together all environment-related fields (WordPress and Gutenberg versions, browser, device, OS).

Update after review feedback:

  • Grouped together description, steps to reproduce, expected vs actual behavior.
  • Make checkboxes optional

Update 2021-08-12:

  • Split description and reproduction steps.
  • Removed "default theme" checkbox and moved the theme information to the environment section.

You can try the proposed changes in this fork.

Screenshots

Current bug report result if fields are empty:

image

Proposed new form (updated with the last changes after review):

image

@priethor priethor self-assigned this Aug 11, 2021
@priethor priethor added the [Type] Project Management Meta-issues related to project management of Gutenberg label Aug 11, 2021
@priethor priethor marked this pull request as ready for review August 11, 2021 10:06
@priethor priethor requested a review from annezazu August 11, 2021 10:06
@priethor priethor changed the title Simplify the bug report form template GitHub Form Templates: Simplify the bug report form template Aug 11, 2021
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @priethor! I've created an issue today and the current form felt kind of overwhelming 😄 .

I like all the changes here! I personally I thought that description and current behavior sections could be combined, but your proposal works well IMO too.

.github/ISSUE_TEMPLATE/Bug_report.yml Show resolved Hide resolved
label: Step-by-step reproduction instructions
description: Please list the steps needed to reproduce the bug.
label: Description ands step-by-step reproduction instructions
description: Please write a brief description of the bug and the steps needed to reproduce it.
placeholder: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is now for both a description and steps needed to reproduce, I'd include something about the description in the placeholder section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any copy suggestions? I feel that adding "When I do '...', it happens '...' is way too similar to the Expected vs Current behavior.

@priethor
Copy link
Contributor Author

Does anybody have strong feelings about combining description and expected vs current behavior? Saying what you expect and what actually happens feels like THE description to me. 😄 cc @annezazu @ntsekouras

@ntsekouras
Copy link
Contributor

Saying what you expect and what actually happens feels like THE description to me

I agree 😄

@priethor
Copy link
Contributor Author

Updated the form to combine description, steps to reproduce, and expected vs actual behavior as part of the description, and updated the PR description accordingly.

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a great improvement! It makes total sense to combine description, expected and current behaviour because there's a lot of overlap in these fields. Steps to reproduce could still be its own field, but perhaps we can revisit this if we find folks aren't adding them in properly.

We could also leave the pre-checks at the top of the form, as a reminder that these are the first steps to take in troubleshooting a bug. I'm not sure whether they should be required or not. Do we get a lot of reports that are actually plugin conflicts and the like? My feeling is no, but perhaps it's just because I haven't been doing a huge amount of triage 😅

@talldan
Copy link
Contributor

talldan commented Aug 12, 2021

I have a slightly opposite opinion, and would like to keep the steps to reproduce separate from the description.

The steps to reproduce are the most important part of the bug report, it's crucial for devs to be able to test and debug the incoming reports. Often without it, reports are too vague to be able to reproduce and we have to ask for more information.

Most reporters are non-technical and don't quite understand what's important information and what isn't. I think combining them like this will lead to reporters only adding a description and skipping the steps to reproduce.

@jasmussen
Copy link
Contributor

Thanks for taking a stab. Can we revisit the question, "Have you tested with a default theme?". A few reasons:

  • It's ambiguous for themes that exist in both classic and block versions.
  • For older default themes like TwentyTwenty, they may have somewhat outdated editor styles that may suggest bugs in the editor that are in fact bugs in the theme itself.

The reports are still valuable, regardless of theme, but just checking the box of testing with a default theme doesn't ensure the issue is that much more valid. We could just ask people to specify which theme they were testing with, that would be valuable.

@javierarce
Copy link
Contributor

javierarce commented Aug 12, 2021

We could also leave the pre-checks at the top of the form, as a reminder that these are the first steps to take in

I have to disagree with this and I'd like to suggest moving the pre-checks to a lower position (at the bottom of the form or at least under the description).

Seeing the description right away is important. Otherwise, we'll need to scan the message and look for the description every time we land on an issue.

image

Update: Also, the original format for that list was better than the one above

image

@talldan
Copy link
Contributor

talldan commented Aug 12, 2021

Seeing the description right away is important. Otherwise, we'll need to scan the message and look for the description every time we land on an issue.

If there was a way to have the checkbox visible on the form, but not in the published description, that would be ideal IMO. Probably not possible though.

@priethor
Copy link
Contributor Author

Good feedback! I have taken the reproduction steps to a different field but left description, expected and actual behavior together, as they seem part of the description. I've also removed the default theme checked and added it to the environment data, it did feel the default theme check was too constrained by the reasons above:

image

@priethor
Copy link
Contributor Author

After letting the last changes sit for a day, I'm merging this for now. If more changes/feedback seem fit, or some of these don't improve the form, I'm happy to iterate over!

@priethor priethor merged commit f802217 into trunk Aug 13, 2021
@priethor priethor deleted the update/bug-report-form-template branch August 13, 2021 07:37
@github-actions github-actions bot added this to the Gutenberg 11.4 milestone Aug 13, 2021
@jasmussen
Copy link
Contributor

👌

@priethor priethor linked an issue Aug 13, 2021 that may be closed by this pull request
3 tasks
@priethor priethor changed the title GitHub Form Templates: Simplify the bug report form template GitHub Issue Forms: Simplify the bug report form template Aug 13, 2021
@talldan
Copy link
Contributor

talldan commented Aug 16, 2021

This looks really good 👍

Thanks for taking the suggestions into account!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project Management] Migrate current issue and PR templates to form templates
7 participants