Update sass version to 1.35.2 with fixes #33433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
mkevins
as code owners
mkaz
added
the
CSS Styling
|
Size Change: -464 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
The version could be also aligned in gutenberg/packages/scripts/package.json Line 75 in 29d2f51 |
|
@gziolo Any thoughts on how to reconcile the sass building and rule for It's possible to also do this in two steps, first update the .scss to remove |
Can we inject the See gutenberg/bin/packages/build-worker.js Lines 95 to 116 in b66e4c5 |
- Updates sass module to 1.35.2 to correct 3 vulnerability warnings - Removes / as a division operator, changes most / 2 to * 0.5 Two deprecation warnings remain that need to be updated to use ``` @use "sass:math"; math.div(numerator, denominator) ``` Warnings in: packages/block-library/src/freeform/editor.scss packages/block-library/src/gallery/style.scss The @use command must be declared prior to any other rules and the way we are building sass for the block-library the files are included and also built stand-alone, so the @use requirement can't be satisfied.
The @use statements must be the first item in sass files and so required refactoring the way we build and insert common import statements.
mkaz
force-pushed
the
update/sass-version
branch
from
83c63dc
to
907dc6e
Compare
gziolo
approved these changes
Jul 19, 2021
gziolo
reviewed
Jul 19, 2021
There was a problem hiding this comment.
My approval was premature 🤣
npm run storybook:build takes some time and it errors at some point. We probably need to add use statement in SCSS file in here:
https://github.com/WordPress/gutenberg/blob/trunk/storybook/style.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two deprecation warnings remain that need to be updated to use
Warnings in:
packages/block-library/src/freeform/editor.scss
packages/block-library/src/gallery/style.scss
The @use command must be declared prior to any other rules and the way
we are building sass for the block-library the files are included and
also built stand-alone, so the @use requirement can't be satisfied.
How has this been tested?
Types of changes
Updates sass module and fixes deprecation warnings