Revert fix/slug-to-classname #32742
Merged
Revert fix/slug-to-classname #32742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -23 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
This was referenced Jun 16, 2021
ockham
reviewed
Jun 16, 2021
Comment on lines
114
to
115
| getColorClassName( 'background', 'Light Purple veryDark' ) | ||
| ).toBe( 'has-Light-Purple-veryDark-background' ); |
There was a problem hiding this comment.
How about we retain this? I think it's a more powerful check than the other one.
|
Updated the tests instructions in the PR and manually tested them myself. It works. |
Tested ✅ |
oandregal
added
the
Backport to WP 6.7 Beta/RC
Tested ✅ |
|
I see there's a test failure: "TypeWriter › should maintain caret position after scroll" that has been reported to fail in other PRs as well. I'd like to address it and help fixing that test but also need to merge this to release 10.8.2, so I'm going to go ahead and merge. |
oandregal
pushed a commit
that referenced
this pull request
Jun 16, 2021
Co-authored-by: Bernie Reiter <ockham@raz.or.at>
38 tasks
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
Co-authored-by: Bernie Reiter <ockham@raz.or.at>
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
Co-authored-by: Bernie Reiter <ockham@raz.or.at>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #32352 that by trying to fix #32347 created issues #32719 and #32721
Third parties (such as Jetpack) rely on specific behaviours from lodash's
kebabCasemethod (see the table at #32347). Because the generated classes are attached to the markup we can't really remove kebabCase as that's the source of the behaviour in use. It seems the way to fix this is by implementing the same behavior around numbers and numerals in the server.While we do that we can gain some time by reverting #32352
How to test
― Test 1
― Test 2
greenslug togreen2greenin thetheme.json.has-green-2-green-color.global-styles-inline-cssstyle tag. Verify thathas-green2green-color,has-green2green-background-colorandhas-green2green-border-color--wp--preset--color--green2green.has-green2green*classes, etc.