Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Breadcrumb: add a rootLabelText prop #32528

Merged
merged 3 commits into from
Jun 10, 2021
Merged

Editor Breadcrumb: add a rootLabelText prop #32528

merged 3 commits into from
Jun 10, 2021

Commits on Jun 9, 2021

  1. Adding a rootLabelText prop to <BlockBreadcrumb /> so that we can… 

    … have flexibility to change the label or just provide a more appropriate label for the "root" element in different editor contexts, for example the Widgets editor root level could be "Widgets". "Document" in the Site Editor could be the name of the site template one day.

Adding snapshot tests

Rebuilding docs
    @ramonjd
    ramonjd committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    e032ef6 View commit details
    Browse the repository at this point in the history

  2. Testing the existence of the root label using react testing library

    @ramonjd
    ramonjd committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    df51d03 View commit details
    Browse the repository at this point in the history

  3. using toBeInTheDocument in place of toBeDefined

    @ramonjd
    ramonjd committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    6423601 View commit details
    Browse the repository at this point in the history