Extract Navigation Block data fetching and management to hook(s) #31825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Block] Navigation
getdave
changed the title
getdave
commented
May 14, 2021
| : false, | ||
| }; | ||
| }, | ||
| [ menuId ] |
There was a problem hiding this comment.
Question: will this selector be retriggered when the selected menu ID (passed from placeholder.js) changes?
There was a problem hiding this comment.
I think so. This should be similar to useEffect dependencies.
|
Size Change: +91 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
May 14, 2021
packages/block-library/src/navigation/use-navigation-entities.js
Outdated
Show resolved
Hide resolved
Mamaduka
reviewed
May 14, 2021
Mamaduka
reviewed
May 14, 2021
Mamaduka
reviewed
May 14, 2021
Mamaduka
reviewed
May 14, 2021
packages/block-library/src/navigation/use-navigation-entities.js
Outdated
Show resolved
Hide resolved
Mamaduka
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the logic for fetching and management of data (eg: Pages, Menus, Menu Items) in the Nav Block is placed inside the
placeholder.jscomponent. As we look to extract reusable logic (possibly into a@wordpress/menuspackage) it's important that important logic such as this is not "buried" within specific components.Moreover, due to being placed inline within a component the data logic is currently all combined and difficult to read / comprehend.
To this end this PR breaks the data fetching out into separate (potentially reusable) hooks for each entity whilst providing a master utility hook
useNavigationEntitieswhich will pull through all entity data in one go.The benefits of this are:
@wordpress/menusif required in future (aligns more closely with the Nav Editor data fetching implementation)How has this been tested?
Check all existing functionality is "as is". Nothing should change.
Particularly check that
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).