Bring implementations of convert nav menu items to blocks back into sync #31602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
getdave
requested review from
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
getdave
commented
May 7, 2021
| @@ -44,6 +44,14 @@ export const menuItemToBlockAttributes = ( { | |||
| type: menuItemTypeField, | |||
| target, | |||
| } ) => { | |||
| // For historical reasons, the `core/navigation-link` variation type is `tag` | |||
There was a problem hiding this comment.
Looks like this got removed. It needs to match the editor's implementation.
|
Size Change: +24 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 10, 2021
getdave
deleted the
fix/align-implementations-convert-nav-menu-items-to-blocks
branch
|
Thanks for the quick follow up @getdave! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like recently there was a regression whereby the matching implementations of
menuItemToBlockAttributesin the Nav editor and block got out of sync.This PR updates both sides and brings everything into sync following mine and @gwwar 's changes in the block and editor.
The fact that this happens points even more strongly towards the need for #31580 to land.
How has this been tested?
Check unit tests pass and both implementations still work correctly:
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).