-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark the __experimentalBlockSettingsMenuFirstItem slot as unstable #31420
Merged
youknowriad
merged 1 commit into
trunk
from
update/mark-first-block-settings-slot-unstable
May 5, 2021
Merged
Mark the __experimentalBlockSettingsMenuFirstItem slot as unstable #31420
youknowriad
merged 1 commit into
trunk
from
update/mark-first-block-settings-slot-unstable
May 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
Issues or PRs that relate to code quality
label
May 3, 2021
Size Change: +6 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #31416
This is an old slot that is meant for internal usage (add the close to sidebar link). We do have an officially supported slot to add items to the block menu which means the need for this particular one is less important and we don't want "order related" hooks. I think we can probably consider refactoring our own usage of it to use the regular slot but for now, I'm just marking it unstable instead of experimental.