Packages: Drop suppport for IE 11 and non-LTS Node.js versions #31270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
gziolo
added
npm Packages
gziolo
force-pushed
the
update/packages-ie11-node-lts
branch
from
b86e196
to
f2436bf
Compare
gziolo
requested review from
adamsilverstein,
adamziel,
ajitbohra,
atimmer,
cameronvoell,
chrisvanpatten,
dmsnell,
draganescu,
ellatrix,
guarani,
kevin940726,
mmtr,
nerrad,
noisysocks,
oandregal,
ntwb,
swissspidy,
talldan and
tellthemachines
as code owners
gziolo
requested review from
youknowriad,
kevin940726,
mmtr,
tellthemachines,
nerrad,
oandregal,
ntwb,
swissspidy,
talldan,
noisysocks,
chrisvanpatten,
adamsilverstein,
adamziel,
ajitbohra and
atimmer
and removed request for
ellatrix,
dmsnell,
kevin940726 and
tellthemachines
scinos
reviewed
Apr 28, 2021
scinos
reviewed
Apr 28, 2021
packages/a11y/package.json
Outdated
| @@ -20,6 +20,9 @@ | |||
| "bugs": { | |||
| "url": "https://github.com/WordPress/gutenberg/issues" | |||
| }, | |||
| "engines": { | |||
| "node": "^12.13.0 || ^14.15.0 || >=15.0.0" | |||
There was a problem hiding this comment.
What's the reason for ^12.13.0 instead of 12.* ?
Also I think you don't need the ||, this field could be represented as 12.* 14.* >=15
There was a problem hiding this comment.
See https://nodejs.org/en/blog/release/v12.13.0/ and https://nodejs.org/en/blog/release/v14.15.0/. Those are versions that were effectively marked as LTS.
Jest uses the same pattern:
https://github.com/facebook/jest/blob/64d5983d20a628d68644a3a4cd0f510dc304805a/package.json#L145-L147
There was a problem hiding this comment.
I think the 12.* 14.* >=15 is logical &&. Not sure though. I have also not found yet references with the ||.
There was a problem hiding this comment.
Those versions are when LTS started, it doesn't mean they are getting updates. Looking at the security releases (eg: https://nodejs.org/en/blog/vulnerability/april-2021-security-releases/), only the very last version of 12.* gets them, so in that sense 12.13.0 is as (in)secure and (un)supported as 12.22.0. Picking the version when the whole 12.* branch was moved to LTS sounds arbitrary to me 🤷🏼
That being said, as we can't specify "latest 12.*", whatever we add in the engines field won't actually prevent them to be installed in unsupported Node versions (even assuming the package managers honors this field by default).
There was a problem hiding this comment.
I don't think that matters that much since it only prints a warning when the version of Node.js is not satisfied. If you are really concerned about that, we can go with a simple >=12.
There was a problem hiding this comment.
Updated to:
"engines": {
"node": ">=12"
},
gziolo
force-pushed
the
update/packages-ie11-node-lts
branch
from
f2436bf
to
6cba72b
Compare
gziolo
force-pushed
the
update/packages-ie11-node-lts
branch
from
6cba72b
to
02544bb
Compare
youknowriad
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to https://make.wordpress.org/core/2021/04/22/ie-11-support-phase-out-plan/.
Follow-up for #31110.
This PR ensures that all WordPress packages that run in the browser include the changelog entry that informs about dropped support for IE 11. It also increases the minimum Node.js versions for the same packages to LTS versions:
Node 10.x goes into "End-of-life" mode this Friday (2021-04-30).
The changelog entry added to packages that summarizes all above:
This PR also updates the note included in README.md files of packages to reflect that IE11 is no longer supported and
@babel/polyfillis deprecated:Types of changes
Breaking changes.
Checklist:
*.native.jsfiles for terms that need renaming or removal).