Block Supports: Allow skipping serialization of border #30035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
the
Global Styles
|
@nosolosw Can I get a super early review here? I'm not sure if I'm missing any big pieces; it's a bit hard to tell since I can't get the border settings to show for the Group and Image blocks at all (even on |
20 tasks
|
Size Change: +8.73 kB (+1%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Sharing here some testing instructions for this PR: How to test:
The expected result is that:
|
oandregal
reviewed
Mar 22, 2021
oandregal
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
This is working properly with the fix at https://github.com/WordPress/gutenberg/pull/30035/files#r598898672
A good next step would be to use this new feature to add support for border via the hooks in the button block, which is using custom UI controls at the moment.
Co-authored-by: André <nosolosw@users.noreply.github.com>
Thanks André! I've applied the fix, and verified that it yields the desired results.
I'll tackle that next 👍 |
ockham
requested review from
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
This was referenced Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #28913. Counterpart to #29142 and #29253.
Find affected blocks by grepping
__experimentalBorderinblock.jsonfiles. This yields theblocks.
How has this been tested?
TBD.
I don't even see the border radius panel for the Group and Image onEdit: I just noticed instructions over at #27667, will try those on Monday.trunk.Anyway, this will need adding
"__experimentalSkipSerialization": trueto the__experimentalBorderobject in theblock.jsonfiles of the Group and Image blocks:Screenshots
TBD