Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: Add PHP Problem Matchers. #29638

Closed
wants to merge 4 commits into from
Closed

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Mar 8, 2021

Description

Add problem matchers for phpunit, and PHPCS.

The phpunit config file is copied from https://github.com/shivammathur/setup-php, which is MIT licensed.

The PHPCS config file is copied over from https://github.com/chekalsky/phpcs-action, which is MIT licensed.

We'll probably need to add a proper copyright/licences notices.

This will cause GitHub to annotate the lines that cause phpunit and PHPCS lint errors in the diff.

TODO

How has this been tested?

TBD

Screenshots

Types of changes

Tooling

@ockham ockham added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Mar 8, 2021
@ockham ockham self-assigned this Mar 8, 2021
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

Size Change: +1.67 kB (0%)

Total Size: 1.4 MB

Filename Size Change
build/a11y/index.js 1.14 kB +1 B (0%)
build/annotations/index.js 3.78 kB -1 B (0%)
build/autop/index.js 2.82 kB +3 B (0%)
build/blob/index.js 665 B +1 B (0%)
build/block-directory/index.js 8.63 kB -6 B (0%)
build/block-editor/index.js 125 kB +715 B (+1%)
build/block-editor/style-rtl.css 12.4 kB +273 B (+2%)
build/block-editor/style.css 12.4 kB +274 B (+2%)
build/block-library/blocks/cover/editor-rtl.css 605 B +215 B (+55%) 🆘
build/block-library/blocks/cover/editor.css 605 B +216 B (+56%) 🆘
build/block-library/blocks/cover/style-rtl.css 1.24 kB -10 B (-1%)
build/block-library/blocks/cover/style.css 1.24 kB -10 B (-1%)
build/block-library/blocks/freeform/editor-rtl.css 2.46 kB +7 B (0%)
build/block-library/blocks/freeform/editor.css 2.46 kB +7 B (0%)
build/block-library/blocks/gallery/editor-rtl.css 696 B +7 B (+1%)
build/block-library/blocks/gallery/editor.css 696 B +6 B (+1%)
build/block-library/blocks/gallery/style-rtl.css 1.11 kB +30 B (+3%)
build/block-library/blocks/gallery/style.css 1.1 kB +30 B (+3%)
build/block-library/blocks/navigation-link/editor-rtl.css 620 B -61 B (-9%)
build/block-library/blocks/navigation-link/editor.css 621 B -62 B (-9%)
build/block-library/blocks/navigation-link/style-rtl.css 671 B -23 B (-3%)
build/block-library/blocks/navigation-link/style.css 668 B -24 B (-3%)
build/block-library/blocks/navigation/editor-rtl.css 1.09 kB -248 B (-18%) 👏
build/block-library/blocks/navigation/editor.css 1.1 kB -243 B (-18%) 👏
build/block-library/blocks/navigation/style-rtl.css 204 B -9 B (-4%)
build/block-library/blocks/navigation/style.css 205 B -9 B (-4%)
build/block-library/blocks/paragraph/style-rtl.css 247 B -41 B (-14%) 👏
build/block-library/blocks/paragraph/style.css 248 B -41 B (-14%) 👏
build/block-library/blocks/query/editor-rtl.css 820 B +6 B (+1%)
build/block-library/blocks/query/editor.css 819 B +7 B (+1%)
build/block-library/blocks/shortcode/editor-rtl.css 512 B +8 B (+2%)
build/block-library/blocks/shortcode/editor.css 512 B +8 B (+2%)
build/block-library/blocks/social-links/editor-rtl.css 776 B +80 B (+11%) ⚠️
build/block-library/blocks/social-links/editor.css 776 B +80 B (+11%) ⚠️
build/block-library/blocks/social-links/style-rtl.css 1.32 kB +9 B (+1%)
build/block-library/blocks/social-links/style.css 1.33 kB +9 B (+1%)
build/block-library/blocks/subhead/editor-rtl.css 0 B -99 B (removed) 🏆
build/block-library/blocks/subhead/editor.css 0 B -99 B (removed) 🏆
build/block-library/blocks/subhead/style-rtl.css 0 B -80 B (removed) 🏆
build/block-library/blocks/subhead/style.css 0 B -80 B (removed) 🏆
build/block-library/blocks/template-part/editor-rtl.css 552 B -5 B (-1%)
build/block-library/blocks/template-part/editor.css 551 B -5 B (-1%)
build/block-library/blocks/verse/editor-rtl.css 50 B -12 B (-19%) 👏
build/block-library/blocks/verse/editor.css 50 B -12 B (-19%) 👏
build/block-library/editor-rtl.css 9.58 kB +12 B (0%)
build/block-library/editor.css 9.58 kB +28 B (0%)
build/block-library/index.js 147 kB -808 B (-1%)
build/block-library/style-rtl.css 8.86 kB -5 B (0%)
build/block-library/style.css 8.86 kB -9 B (0%)
build/block-library/theme-rtl.css 700 B -36 B (-5%)
build/block-library/theme.css 701 B -35 B (-5%)
build/blocks/index.js 48.3 kB +58 B (0%)
build/components/index.js 284 kB +329 B (0%)
build/components/style-rtl.css 16.2 kB +614 B (+4%)
build/components/style.css 16.2 kB +615 B (+4%)
build/compose/index.js 11.2 kB +90 B (+1%)
build/core-data/index.js 16.7 kB +4 B (0%)
build/customize-widgets/index.js 3.95 kB -4 B (0%)
build/data-controls/index.js 830 B +2 B (0%)
build/data/index.js 8.87 kB -6 B (0%)
build/dom-ready/index.js 576 B -1 B (0%)
build/dom/index.js 4.96 kB +28 B (+1%)
build/edit-navigation/index.js 11.9 kB +132 B (+1%)
build/edit-navigation/style-rtl.css 1.31 kB +30 B (+2%)
build/edit-navigation/style.css 1.31 kB +30 B (+2%)
build/edit-post/index.js 307 kB +483 B (0%)
build/edit-post/style-rtl.css 6.88 kB +62 B (+1%)
build/edit-post/style.css 6.87 kB +63 B (+1%)
build/edit-site/index.js 27.2 kB -46 B (0%)
build/edit-site/style-rtl.css 4.5 kB +36 B (+1%)
build/edit-site/style.css 4.5 kB +33 B (+1%)
build/edit-widgets/index.js 20.2 kB +31 B (0%)
build/editor/editor-styles-rtl.css 347 B -196 B (-36%) 🎉
build/editor/editor-styles.css 347 B -198 B (-36%) 🎉
build/editor/index.js 41.8 kB -257 B (-1%)
build/editor/style-rtl.css 3.9 kB +4 B (0%)
build/editor/style.css 3.9 kB +4 B (0%)
build/element/index.js 4.61 kB +1 B (0%)
build/format-library/index.js 6.75 kB -8 B (0%)
build/hooks/index.js 2.28 kB -1 B (0%)
build/html-entities/index.js 623 B +1 B (0%)
build/is-shallow-equal/index.js 698 B -1 B (0%)
build/keyboard-shortcuts/index.js 2.53 kB +4 B (0%)
build/keycodes/index.js 1.95 kB -1 B (0%)
build/list-reusable-blocks/index.js 3.14 kB -2 B (0%)
build/media-utils/index.js 5.34 kB -1 B (0%)
build/notices/index.js 1.85 kB +1 B (0%)
build/nux/index.js 3.41 kB +4 B (0%)
build/plugins/index.js 2.89 kB -6 B (0%)
build/primitives/index.js 1.42 kB +1 B (0%)
build/redux-routine/index.js 2.84 kB +5 B (0%)
build/reusable-blocks/index.js 3.78 kB -1 B (0%)
build/rich-text/index.js 13.4 kB +5 B (0%)
build/server-side-render/index.js 2.58 kB -235 B (-8%)
build/shortcode/index.js 1.7 kB -1 B (0%)
build/token-list/index.js 1.27 kB +1 B (0%)
build/url/index.js 3.02 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/api-fetch/index.js 3.4 kB 0 B
build/block-directory/style-rtl.css 1 kB 0 B
build/block-directory/style.css 1.01 kB 0 B
build/block-library/blocks/archives/editor-rtl.css 61 B 0 B
build/block-library/blocks/archives/editor.css 60 B 0 B
build/block-library/blocks/audio/editor-rtl.css 58 B 0 B
build/block-library/blocks/audio/editor.css 58 B 0 B
build/block-library/blocks/audio/style-rtl.css 112 B 0 B
build/block-library/blocks/audio/style.css 112 B 0 B
build/block-library/blocks/block/editor-rtl.css 161 B 0 B
build/block-library/blocks/block/editor.css 161 B 0 B
build/block-library/blocks/button/editor-rtl.css 475 B 0 B
build/block-library/blocks/button/editor.css 474 B 0 B
build/block-library/blocks/button/style-rtl.css 479 B 0 B
build/block-library/blocks/button/style.css 479 B 0 B
build/block-library/blocks/buttons/editor-rtl.css 315 B 0 B
build/block-library/blocks/buttons/editor.css 315 B 0 B
build/block-library/blocks/buttons/style-rtl.css 364 B 0 B
build/block-library/blocks/buttons/style.css 363 B 0 B
build/block-library/blocks/calendar/style-rtl.css 208 B 0 B
build/block-library/blocks/calendar/style.css 208 B 0 B
build/block-library/blocks/categories/editor-rtl.css 84 B 0 B
build/block-library/blocks/categories/editor.css 83 B 0 B
build/block-library/blocks/categories/style-rtl.css 79 B 0 B
build/block-library/blocks/categories/style.css 79 B 0 B
build/block-library/blocks/code/style-rtl.css 90 B 0 B
build/block-library/blocks/code/style.css 90 B 0 B
build/block-library/blocks/columns/editor-rtl.css 190 B 0 B
build/block-library/blocks/columns/editor.css 190 B 0 B
build/block-library/blocks/columns/style-rtl.css 421 B 0 B
build/block-library/blocks/columns/style.css 421 B 0 B
build/block-library/blocks/embed/editor-rtl.css 486 B 0 B
build/block-library/blocks/embed/editor.css 486 B 0 B
build/block-library/blocks/embed/style-rtl.css 401 B 0 B
build/block-library/blocks/embed/style.css 400 B 0 B
build/block-library/blocks/file/editor-rtl.css 199 B 0 B
build/block-library/blocks/file/editor.css 198 B 0 B
build/block-library/blocks/file/style-rtl.css 248 B 0 B
build/block-library/blocks/file/style.css 248 B 0 B
build/block-library/blocks/group/editor-rtl.css 318 B 0 B
build/block-library/blocks/group/editor.css 317 B 0 B
build/block-library/blocks/group/style-rtl.css 57 B 0 B
build/block-library/blocks/group/style.css 57 B 0 B
build/block-library/blocks/heading/editor-rtl.css 129 B 0 B
build/block-library/blocks/heading/editor.css 129 B 0 B
build/block-library/blocks/heading/style-rtl.css 76 B 0 B
build/block-library/blocks/heading/style.css 76 B 0 B
build/block-library/blocks/html/editor-rtl.css 281 B 0 B
build/block-library/blocks/html/editor.css 281 B 0 B
build/block-library/blocks/image/editor-rtl.css 717 B 0 B
build/block-library/blocks/image/editor.css 716 B 0 B
build/block-library/blocks/image/style-rtl.css 476 B 0 B
build/block-library/blocks/image/style.css 478 B 0 B
build/block-library/blocks/latest-comments/editor-rtl.css 159 B 0 B
build/block-library/blocks/latest-comments/editor.css 158 B 0 B
build/block-library/blocks/latest-comments/style-rtl.css 269 B 0 B
build/block-library/blocks/latest-comments/style.css 269 B 0 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B 0 B
build/block-library/blocks/latest-posts/editor.css 137 B 0 B
build/block-library/blocks/latest-posts/style-rtl.css 523 B 0 B
build/block-library/blocks/latest-posts/style.css 522 B 0 B
build/block-library/blocks/list/editor-rtl.css 65 B 0 B
build/block-library/blocks/list/editor.css 65 B 0 B
build/block-library/blocks/list/style-rtl.css 63 B 0 B
build/block-library/blocks/list/style.css 63 B 0 B
build/block-library/blocks/media-text/editor-rtl.css 191 B 0 B
build/block-library/blocks/media-text/editor.css 191 B 0 B
build/block-library/blocks/media-text/style-rtl.css 535 B 0 B
build/block-library/blocks/media-text/style.css 532 B 0 B
build/block-library/blocks/more/editor-rtl.css 434 B 0 B
build/block-library/blocks/more/editor.css 434 B 0 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B 0 B
build/block-library/blocks/nextpage/editor.css 395 B 0 B
build/block-library/blocks/page-list/editor-rtl.css 215 B 0 B
build/block-library/blocks/page-list/editor.css 215 B 0 B
build/block-library/blocks/page-list/style-rtl.css 527 B 0 B
build/block-library/blocks/page-list/style.css 526 B 0 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B 0 B
build/block-library/blocks/paragraph/editor.css 157 B 0 B
build/block-library/blocks/post-author/editor-rtl.css 209 B 0 B
build/block-library/blocks/post-author/editor.css 209 B 0 B
build/block-library/blocks/post-author/style-rtl.css 183 B 0 B
build/block-library/blocks/post-author/style.css 184 B 0 B
build/block-library/blocks/post-comments-form/style-rtl.css 250 B 0 B
build/block-library/blocks/post-comments-form/style.css 250 B 0 B
build/block-library/blocks/post-content/editor-rtl.css 139 B 0 B
build/block-library/blocks/post-content/editor.css 139 B 0 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B 0 B
build/block-library/blocks/post-excerpt/editor.css 73 B 0 B
build/block-library/blocks/post-featured-image/editor-rtl.css 338 B 0 B
build/block-library/blocks/post-featured-image/editor.css 338 B 0 B
build/block-library/blocks/post-featured-image/style-rtl.css 100 B 0 B
build/block-library/blocks/post-featured-image/style.css 100 B 0 B
build/block-library/blocks/preformatted/style-rtl.css 63 B 0 B
build/block-library/blocks/preformatted/style.css 63 B 0 B
build/block-library/blocks/pullquote/editor-rtl.css 183 B 0 B
build/block-library/blocks/pullquote/editor.css 183 B 0 B
build/block-library/blocks/pullquote/style-rtl.css 318 B 0 B
build/block-library/blocks/pullquote/style.css 318 B 0 B
build/block-library/blocks/query-loop/editor-rtl.css 90 B 0 B
build/block-library/blocks/query-loop/editor.css 89 B 0 B
build/block-library/blocks/query-loop/style-rtl.css 315 B 0 B
build/block-library/blocks/query-loop/style.css 317 B 0 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B 0 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B 0 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B 0 B
build/block-library/blocks/query-pagination/editor.css 262 B 0 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B 0 B
build/block-library/blocks/query-pagination/style.css 168 B 0 B
build/block-library/blocks/query-title/editor-rtl.css 86 B 0 B
build/block-library/blocks/query-title/editor.css 86 B 0 B
build/block-library/blocks/quote/editor-rtl.css 61 B 0 B
build/block-library/blocks/quote/editor.css 61 B 0 B
build/block-library/blocks/quote/style-rtl.css 169 B 0 B
build/block-library/blocks/quote/style.css 169 B 0 B
build/block-library/blocks/rss/editor-rtl.css 201 B 0 B
build/block-library/blocks/rss/editor.css 202 B 0 B
build/block-library/blocks/rss/style-rtl.css 290 B 0 B
build/block-library/blocks/rss/style.css 290 B 0 B
build/block-library/blocks/search/editor-rtl.css 165 B 0 B
build/block-library/blocks/search/editor.css 165 B 0 B
build/block-library/blocks/search/style-rtl.css 342 B 0 B
build/block-library/blocks/search/style.css 344 B 0 B
build/block-library/blocks/separator/editor-rtl.css 99 B 0 B
build/block-library/blocks/separator/editor.css 99 B 0 B
build/block-library/blocks/separator/style-rtl.css 236 B 0 B
build/block-library/blocks/separator/style.css 236 B 0 B
build/block-library/blocks/site-logo/editor-rtl.css 201 B 0 B
build/block-library/blocks/site-logo/editor.css 201 B 0 B
build/block-library/blocks/site-logo/style-rtl.css 115 B 0 B
build/block-library/blocks/site-logo/style.css 115 B 0 B
build/block-library/blocks/social-link/editor-rtl.css 164 B 0 B
build/block-library/blocks/social-link/editor.css 165 B 0 B
build/block-library/blocks/spacer/editor-rtl.css 317 B 0 B
build/block-library/blocks/spacer/editor.css 317 B 0 B
build/block-library/blocks/spacer/style-rtl.css 48 B 0 B
build/block-library/blocks/spacer/style.css 48 B 0 B
build/block-library/blocks/table/editor-rtl.css 478 B 0 B
build/block-library/blocks/table/editor.css 478 B 0 B
build/block-library/blocks/table/style-rtl.css 402 B 0 B
build/block-library/blocks/table/style.css 402 B 0 B
build/block-library/blocks/tag-cloud/editor-rtl.css 118 B 0 B
build/block-library/blocks/tag-cloud/editor.css 118 B 0 B
build/block-library/blocks/tag-cloud/style-rtl.css 94 B 0 B
build/block-library/blocks/tag-cloud/style.css 94 B 0 B
build/block-library/blocks/term-description/editor-rtl.css 90 B 0 B
build/block-library/blocks/term-description/editor.css 90 B 0 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B 0 B
build/block-library/blocks/text-columns/editor.css 95 B 0 B
build/block-library/blocks/text-columns/style-rtl.css 166 B 0 B
build/block-library/blocks/text-columns/style.css 166 B 0 B
build/block-library/blocks/verse/style-rtl.css 87 B 0 B
build/block-library/blocks/verse/style.css 87 B 0 B
build/block-library/blocks/video/editor-rtl.css 504 B 0 B
build/block-library/blocks/video/editor.css 503 B 0 B
build/block-library/blocks/video/style-rtl.css 187 B 0 B
build/block-library/blocks/video/style.css 187 B 0 B
build/block-library/common-rtl.css 1.1 kB 0 B
build/block-library/common.css 1.1 kB 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/customize-widgets/style-rtl.css 168 B 0 B
build/customize-widgets/style.css 168 B 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 769 B 0 B
build/edit-widgets/style-rtl.css 3.2 kB 0 B
build/edit-widgets/style.css 3.2 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/style-rtl.css 637 B 0 B
build/format-library/style.css 639 B 0 B
build/i18n/index.js 4.01 kB 0 B
build/list-reusable-blocks/style-rtl.css 629 B 0 B
build/list-reusable-blocks/style.css 628 B 0 B
build/nux/style-rtl.css 731 B 0 B
build/nux/style.css 727 B 0 B
build/priority-queue/index.js 791 B 0 B
build/react-i18n/index.js 1.46 kB 0 B
build/reusable-blocks/style-rtl.css 225 B 0 B
build/reusable-blocks/style.css 225 B 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@ockham ockham force-pushed the add/php-problem-matchers branch 3 times, most recently from 34f2438 to 8355f2d Compare July 7, 2021 10:47
@Mamaduka
Copy link
Member

Mamaduka commented Mar 9, 2023

I think this was resolved by #46510. @anton-vlasenko can you confirm?

@Mamaduka Mamaduka closed this May 4, 2023
@anton-vlasenko
Copy link
Contributor

anton-vlasenko commented May 4, 2023

@Mamaduka Sorry, somehow I forgot to reply to your comment. Yes, the issue should have been resolved by #46510.

Regarding the use of problem matchers: let's stick to using cs2pr (just as Core does). This will allow keep Gutenberg and Core CI jobs in sync and will ease the backporting efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants