First step towards hybrid themes: Fallback to PHP templates #29026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
aristath
changed the title
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
gziolo
added
[Feature] Themes
|
I have tested this by adding a block-templates folder inside Twenty Seventeen. I was also able to: I added 404.php and archive.php files to a full site editing theme. I added a category.php file and this was used correctly for category archives. I then tried creating a new 404 template in the site editor. |
|
@carolinan for custom 404 templates there is an unrelated issue with the slugs which prevents numeric values as a slug. If you check the slug for the created 404 template you should see it's |
|
In Appearance > Templates there is no 404 template saved for the FSE theme. There is a saved 404 from Twenty Seventeen 🤔 |
draganescu
reviewed
Feb 26, 2021
|
What's blocking this? Do you think it's ready to be tried? Do we want to add some documentation first? Maybe to this page https://developer.wordpress.org/block-editor/how-to-guides/block-based-theme/ |
draganescu
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
@youknowriad nothing is blocking us from landing this and seeing how it works.
|
Some documentation for this would be good though |
6 tasks
This was referenced Apr 7, 2021
This was referenced May 4, 2021
ockham
added a commit
that referenced
this pull request
May 12, 2021
The block template resolution algorithm is quite complex, as it has to cover quite a lot of different possible cases resulting from various combinations of - WP's "old" template hierarchy (including custom page templates, and child themes) - block templates. Things become especially complex when there are e.g. "oldschool" PHP templates with higher specificity than the available block templates; or when a child theme has a PHP template with equal specificity as the parent theme's corresponding block template. For more discussion on this, see #31399. Examples of previous iterations that sought to refine the algorithms' behavior include #29026, #30599, #31123, and #31336. This PR's goal is to eventually cover all of those cases.
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 1st step towards hybrid themes - see #29024 for details.
Adds a backwards-compatibility layer to the FSE templating system, allowing themes to fallback to legacy (.php) templates depending on the specificity/priority of php templates & block templates.
Important note: This PR only addresses the frontend without changing anything on the editor side. It is not meant to be a complete implementation, but it is a good way to start thinking about what comes next.
Example:
Loading a page with title "About" and ID = 1725 will try to load templates in the following order:
page-about.phppage-1725.phppage.phpsingular.phpindex.phpIf it doesn't find the 1st one then it will try the 2nd one and so on. The same hierarchy & priorities are used for block templates, however there is a disconnect and FSE will be either on, or off. If FSE is on, then it will look at the block templates only. If FSE is off, it will look at the PHP templates only.
With this PR, if a theme has an
indexblock-template, it will be used as a fallback. If the theme has apage.phpfile, it will be used for pages. If the user creates apageblock-template, it will override the php file. If they create apage-1725.phpfile in their theme, it will override the block-template.This allows for more granular control and will eventually allow themes to start migrating parts of their templates.
How has this been tested?
Tested by creating block templates in an FSE theme and then PHP templates, making sure that block templates override php templates on the same level (
pageblock-template overridespage.phpbut notpage-1725.php)Backwards-compatibility:
Nothing changes for existing FSE themes. This is not a complete solution for hybrid themes, but it is the 1st step to allow further improvements and doesn't break backwards-compatibility with anything we've done so far.
Checklist:
I've included developer documentation if appropriate.I've updated all React Native files affected by any refactorings/renamings in this PR.