Global Styles: enqueue preset classes in the front-end #28792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be blocks that don't support any style but still have the presets declared as settings. In these cases, we still need to process the settings.
oandregal
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
oandregal
changed the title
|
I just ran into this in the latest version of the TT1 Blocks theme. Once this is fixed, if presets are defined in the "default", there is no need to define them again in "root" unless you want to override the defaults, correct? The workaround right now, is to just add them to both so the classes get enqueued. I am also running into this issue in the Site Editor WordPress/theme-experiments#201, and not sure if it is related, sorry if this is the wrong place to mention. But can't tell is the specification is incorrect in the TT1 theme, or there is a larger underlying issue like this ticket identified. |
3 tasks
aristath
approved these changes
Feb 8, 2021
oandregal
changed the title
oandregal
pushed a commit
that referenced
this pull request
Feb 8, 2021
* Reproduce bug * Fix for all blocks selector There may be blocks that don't support any style but still have the presets declared as settings. In these cases, we still need to process the settings.
|
Hi @aristath, I only just noticed a small issue, in that when the global styles have been edited, the theme defined styles are rendered after the edited styles, so the edited styles do not override the theme defaults. It may be it simply needs the order switching around, I'm not too sure. Also I'm not sure whether to open a new issue or mention it here. I'm new at this so apologies in advance if this is not the correct method. |
|
Hi @nosolosw and @aristath again sorry if this is wrong place to mention this. Just to further elaborate, to test I used this very basic theme.json: If we go into the Site Editor and change the accent color to In the screenshot, the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28780
#28533 split
globalintorootanddefaults, with the goal of making it easier to share settings among the different blocks and still be able to set therootblock independently. In doing so, it missed that, in the frontend, thedefaultspresets should also enqueue the classes for them. This adds them back.How to test
masterbranch..has-black-color,.has-dark-gray,.has-purple-to-yellow-gradient,.has-extra-small-font-size,.has-small-font-size, etc.