Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Editor: Improve experience for user creating their first menu #28767

Merged
merged 22 commits into from
Feb 15, 2021
Merged

Navigation Editor: Improve experience for user creating their first menu #28767

merged 22 commits into from
Feb 15, 2021

Commits on Feb 12, 2021

  1. Ensure a navigation post cannot be returned with a null menu id

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    0091075 View commit details
    Browse the repository at this point in the history

  2. Show empty state when there are no menus

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    f080f2a View commit details
    Browse the repository at this point in the history

  3. Add loading spinner to empty state

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    4b7f7de View commit details
    Browse the repository at this point in the history

  4. Add some styling

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    e6fc973 View commit details
    Browse the repository at this point in the history

  5. Finesse loading states

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    3253561 View commit details
    Browse the repository at this point in the history

  6. Tidy up variables

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    e647104 View commit details
    Browse the repository at this point in the history

  7. Refactor AddMenuForm to general component

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    69f64d3 View commit details
    Browse the repository at this point in the history

  8. Add the menu creation form to the empty state

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    748dbd2 View commit details
    Browse the repository at this point in the history

  9. Update contents of add menu form to match design

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    dea5452 View commit details
    Browse the repository at this point in the history

  10. Style the add menu form

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    ba1db28 View commit details
    Browse the repository at this point in the history

  11. Hide header items when creating first menu

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    e012115 View commit details
    Browse the repository at this point in the history

  12. Remove autofocus

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    35bf5bc View commit details
    Browse the repository at this point in the history

  13. Reduce forehead

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    59fb40f View commit details
    Browse the repository at this point in the history

  14. Move heading element inside form and remove wrapper div

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    972660c View commit details
    Browse the repository at this point in the history

  15. Hide block inspector when creating first menu

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    23bf9b6 View commit details
    Browse the repository at this point in the history

  16. Add autofocus back

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    841e222 View commit details
    Browse the repository at this point in the history

  17. Move the loading spinner into layout and style

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    ba06ffb View commit details
    Browse the repository at this point in the history

  18. Update e2e test

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    86553a5 View commit details
    Browse the repository at this point in the history

  19. Fix linting issue caused by git

    @talldan
    talldan committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    d279406 View commit details
    Browse the repository at this point in the history

  20. Wrap boolean logic 

    Co-authored-by: Kai Hao <kevin830726@gmail.com>
    @talldan @kevin940726
    talldan and kevin940726 authored Feb 12, 2021
    Configuration menu
    Copy the full SHA
    7c3ce3d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Avoid calling selector instead of returning early from selector

    @talldan
    talldan committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    632437b View commit details
    Browse the repository at this point in the history

  2. Coerce to boolean

    @talldan
    talldan committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    2f04009 View commit details
    Browse the repository at this point in the history