Refactor the core-data store to thunks
#28389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Status] In Progress
|
Size Change: -133 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
This should be easier now that #28210 is merged. |
noisysocks
added
the
[Type] Code Quality
This was referenced Aug 25, 2021
jsnajdr
force-pushed
the
thunkify/core-data
branch
2 times, most recently
from
487cd48
to
7b614cb
Compare
This was referenced Aug 30, 2021
jsnajdr
force-pushed
the
thunkify/core-data
branch
2 times, most recently
from
3f770ef
to
667a431
Compare
|
@adamziel I now rebased this PR onto the recently merged changes and it's now half the size 🙂 Things that remain is the |
jsnajdr
force-pushed
the
thunkify/core-data
branch
from
667a431
to
eef42e3
Compare
This was referenced Sep 6, 2021
Merged
|
@jsnajdr Yay! I split the resolvers migration into a few PRs referenced above. Once merged, they should cover all the resolvers and their related tests. |
|
And this should take care of entities.js: #34582 |
jsnajdr
force-pushed
the
thunkify/core-data
branch
2 times, most recently
from
e17d093
to
5dd55fd
Compare
|
@adamziel Now the last thing to migrate is the The rebased PR contains a series of additional cleanups: please have a look at the individual commits. |
adamziel
force-pushed
the
thunkify/core-data
branch
from
e6873d9
to
1ce7581
Compare
|
This is great! |
fullofcaffeine
added a commit
that referenced
this pull request
Sep 9, 2021
* trunk: (214 commits) Fix snackbar overflow on nav editor (#34661) Mobile - Allow disabling text and background color via theme.json (#34633) Fix disabled blocks logical error on Widgets screen (#34634) [Mobile] - Global styles - Add support to render font sizes and line height (#34144) ESLint Plugin: Update eslint jsdoc dependency (#34338) Scripts: Add CHANGELOG entry for `jest-dev-server` upgrade (#34657) Bump jest-dev-server to v5 (#34560) Refactor the `core-data` store to thunks (#28389) Only capture toolbars on parent Nav block when not in vertical mode (#34615) Update Changelog for 11.5.0-rc.1 Bump plugin version to 11.5.0-rc.1 Gallery block: Fix media placeholder height in site editor (#34629) Border Controls: Display color indicator and check selected color (#34467) Remove horizontal and vertical navigation block variations from inserter (#34614) AlignmentMatrixControl : Fix/update docs (#34624) Gap block support: force gap change to cause the block to re-render (fix Safari issue) (#34567) [Block Library - Social Links]: Use the new `flex` layout (#34493) [Mobile] Update the bottom sheet header (#34309) Group block: Add a row variation (#34535) Migrate entities.js to thunks (#34582) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of the thunks support added in #27276 and refactors the
core-dataactions and resolvers.Still a work in progress: we'll need to update unit tests and fix the request batching implementation before the updated editor really starts working.