Global Styles: Use context when translating entries in theme.json #28246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
commented
Jan 15, 2021
lib/class-wp-theme-json-resolver.php
Outdated
| // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText,WordPress.WP.I18n.NonSingularStringLiteralDomain | ||
| $item_to_translate[ $translatable_key ] = translate( $item_to_translate[ $translatable_key ], $domain ); | ||
| // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText,WordPress.WP.I18n.NonSingularStringLiteralContext,WordPress.WP.I18n.NonSingularStringLiteralDomain | ||
| $item_to_translate[ $translatable_key ] = translate_with_gettext_context( $item_to_translate[ $translatable_key ], sprintf( 'theme %s %s', $path, $translatable_key ), $domain ); |
There was a problem hiding this comment.
I haven't try to execute it yet. I'm more flagging this issue that wasn't addressed in the original PR.
@jorgefilipecosta, any recommendations on how to compute the context name based on the path?
|
Could you provide some examples of the expected contexts? |
gziolo
added
the
Internationalization (i18n)
I was hoping that @jorgefilipecosta will do in the last minutes before he goes on the second part of his parental leave 😆 |
gziolo
added
the
Global Styles
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
I guess we can add the contexts to file lib/experimental-i18n-theme.json. Into something like: |
|
Hey, I wanted to share that I'm working on making |
This was referenced Jan 23, 2021
|
👋 I'm looking at this in the context of #27506 so I'm going to push any commits directly if that's ok. First step: load my brain with the past conversations about this. |
oandregal
force-pushed
the
update/theme-json-i18n
branch
from
dbe6b90
to
9d6b04e
Compare
oandregal
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
@swissspidy @aristath This is ready for review. Going to make #28783 work based on these changes. |
swissspidy
approved these changes
Feb 9, 2021
gziolo
commented
Feb 9, 2021
This was referenced Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attaches a translation context to the strings defined in
experimental-theme.json, following the conversations atblock.json– Blocks: Add i18n support to register_block_type_from_metadata wordpress-develop#868 (comment)theme.json– Add theme.json i18n mechanism and JSON file specifying which theme.json paths are translatable #27380 (comment)It uses an auxiliary structure defined #28246 (comment) to know which data should be translated.
How to test