Fix entity spotlight system. #28239
Merged
Fix entity spotlight system. #28239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
added
[Type] Bug
Addison-Stavlo
requested review from
mattwiebe,
vindl,
Copons,
david-szabo97,
jeyip and
noahtallen
|
Size Change: +110 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
This was referenced Jan 15, 2021
jameskoster
approved these changes
Jan 15, 2021
TestingBehaviorClicking on a template part inner block dims all content outside of the template part for:
Browsers
I couldn't test IE11 because of an existing bug on master that borks the full site editor. For some reason, when I try to visit it, the editor automatically removes "Fullscreen mode" and displays a wsod like so:
I don't think the IE11 issue should block the spotlight code changes since the problem existed prior to this PR. |
|
Issue for the IE11 bug #28249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the entity spotlight system that was broken in #27271. The noted PR stripped the CSS that enabled this system with little to no discussion or explanation and for the sake of testing a hover border system that it did not conflict with.
Adding this missing CSS back in this PR will re-enable the spotlight mode for template-parts, if this needs to be disabled for template parts this should be done by editing the settings array passed on initialization of the editor and not by removing the styles for the system. However, clarity of what is/is not part of the template part currently being edited is a very large concern and this spotlight works with other tools to solve this issue (I will re-add the border states that were also stripped in a separate PR). Until we have other systems to appropriately convey this designed and implemented, we should not be removing the entity spotlight.
How has this been tested?
Screenshots
Types of changes
Checklist: