Add an outline mode and use it both Site Editor and Template mode #27499
Conversation
youknowriad
added
[Feature] Full Site Editing
[Type] Experimental
|
Size Change: -298 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
There's a lot of CSS removed here, and when testing it I'm not seeing the exact same behavior of outlines in the site editor. The heuristic we decided to test for starters was:
I'd like Jay who worked on this to test it a bit more indepthly in case I'm missing something, but it feels different. This is purely an under the hood change, correct? Not surfaced in any prefs menu right? |
|
Yes, under the hood and the removal of CSS is because for me it didn't feel like it deserved a dedicated style while we already had the style (the one we use for select mode) |
|
I believe the per-state visual treatments Joen mentioned are an a11y requirement, so probably best to retain them. The only other thing I see missing is the |
|
It's more a matter of us intentionally wanting to try out that new style as discussed in #27271. While there's always room for improvement, it's barely been tested yet and I think it's way too early to decide it didn't work. |
|
I can restore the styles but to be honest, I didn't even notice the difference myself so I really doubt we need any particular treatment here |
|
I'm recording some demo work right now, and I've found a couple of things I want to tweak:
But despite that, it feels like a really good balance that I think can be polished to work very well. I think we should keep it and refine it, and revisit in a few releases. Thank you Riad. |
| @@ -122,6 +122,7 @@ function BlockListBlock( { | |||
| isDragging: isBlockBeingDragged( clientId ), | |||
| isHighlighted: isBlockHighlighted( clientId ), | |||
| isFocusMode: getSettings().focusMode, | |||
| isOutlineMode: getSettings().outlineMode, | |||
There was a problem hiding this comment.
Nitpick - call getSettings once and extract props?
This PR moves the Adhoc outlines revealing implemented in edit-site into a dedicated mode of the block-editor package and uses that mode in both Site Editor and the template mode of the post editor.