Adds back in icon and title for gallery block #27293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmatosed
added
the
[Block] Gallery
jasmussen
approved these changes
Nov 26, 2020
|
Size Change: +14 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
I just refactored based on your advice @jasmussen, it seems some classes do need to get back and that's great we can still have benefits but select a little more exact. Here is the full flow running this PR (note it uses the modern style now which 5.5 introduced so that's the visual difference - so great to see the iterations there):
|
|
All good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gallery block's title and icon are missing as of the latest build. Here is what currently shows - giving context with other blocks.
Before:
It seems as if this was removed as part of G2 PR #19344. As the other blocks still have these, I would suggest bringing them back for the gallery block.
After:
Additional fixes included
In addition to bringing back these, I also brought in a padding inheritance fix for the block on hover. There are no visual changes as a result to that. Props to @jasmussen for noting in #27252 this could be reduced in code. I'm adding this to group iterations.
I also discovered that I could remove the margin value from the button as part of this fix now it's inheriting. Here is after on select:
Feedback
I'd love a code review to check everything is working and also input whether this is a suitable reverting.