Refactor GalleryImage to use React hooks #25305
Conversation
ZebulanStanphill
added
[Block] Gallery
|
@ZebulanStanphill I pushed up a commit which updates the |
| onSelectImage() { | ||
| if ( ! this.props.isSelected ) { | ||
| this.props.onSelect(); | ||
| const onSelectCaption = () => { |
There was a problem hiding this comment.
Personally, I prefer named functions, because they're easier to debug. I don't think there's a good reason to assign anonymous functions to a constant here.
|
just a note that this is going to be in conflict with some of the work in #25940, and also with some native code refactoring that is being done in relation to that ... obviously we can just pick through the changes when we are able to rebase again if this change is urgent and needs to go in before we finish the gallery refactor, but just highlighting in case this change can be deferred until gallery changes are finalised. @dratwas do you have any thoughts on whether we try and get this rebased into the gallery PR before you branch off again to to finish the native work there, or not? |
Hey @glendaviesnz, thanks for asking :) AFAIK we will remove these files during the gallery refactor work so there is no difference for me :) Resolving conflicts should not be a problem in that case. |
🤦 Doh! must have been a bad day yesterday, even after looking at the file I had 'Image' component in my mind instead of 'GalleryImage' ... @ravichdev & @ellatrix completely ignore my irrelevant comment! ... but just be aware that this component will be deleted if we manage to get the Gallery refactor merged. |
|
Hey there! can we rebase and land this? |
|
@ravichdev I think this needs a rebase and some conflicts need to be resolved. Is that something you'd be able to look into? |
It maybe isn't worth landing this now as gallery refactor is close to being merged as the mobile work is complete, and the gallery image component is being deprecated. The old gallery image component code will live in a deprecated subfolder for a short period, but unlikely to get any further development. |
|
Going to close this. Now that the gallery refactor is merged the old version of the gallery code is being deprecated, so probably not worth refactoring at this point. |
Description
Related to #22890
Refactor GalleryImage component to use React hooks
How has this been tested?
Types of changes
Refactor class component to functional component and use React hooks
Checklist: